Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the support link from the CLI output #4126

Closed
honnibal opened this issue Jun 27, 2020 · 2 comments · Fixed by #4496
Closed

Consider removing the support link from the CLI output #4126

honnibal opened this issue Jun 27, 2020 · 2 comments · Fixed by #4496
Assignees
Labels
enhancement Enhances DVC help wanted p1-important Important, aka current backlog of things to do ui user interface / interaction

Comments

@honnibal
Copy link

honnibal commented Jun 27, 2020

This is definitely a matter of opinion, but I wanted to raise my own reaction and see how others feel.

Personally, I hate the support link that's printed after every error, so much so that I'm thinking of making myself an alias or something that strips it out.

The message is uninformative, especially after the first time it's shown. It also really feels out of place for an open-source tool. As a user I might write a dozen commands in a few minutes that each end with exit 1. So my screen is just full of this message, Having any troubles? Hit us up at https://dvc.org/support, we are always happy to help!, over and over again. This quickly creates quite the opposite feeling from what you're going for.

Anyway, this is definitely subjective, and it intersects with strategic considerations etc. So, up to you! But I thought I'd at least mention my reaction to it.

@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Jun 27, 2020
@efiop
Copy link
Contributor

efiop commented Jun 29, 2020

Hi @honnibal !

Thanks for the feedback! Indeed, printing the footer on every error might be a bit too much. I think we could safely switch to printing it only on unexpected errors. So we would move

logger.info(FOOTER)
to around
ret = 255
. What do you think?

@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Jun 29, 2020
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Jun 29, 2020
@efiop efiop added the ui user interface / interaction label Jun 29, 2020
@honnibal
Copy link
Author

I think that sounds like a good step, sure! After all, most of my errors will be things like getting a URL or a path wrong. It doesn't make sense to be told about support in these situations.

@efiop efiop added enhancement Enhances DVC p2-medium Medium priority, should be done, but less important help wanted labels Jun 30, 2020
@efiop efiop removed the awaiting response we are waiting for your reply, please respond! :) label Jul 9, 2020
@efiop efiop self-assigned this Aug 30, 2020
@efiop efiop added p1-important Important, aka current backlog of things to do and removed p2-medium Medium priority, should be done, but less important labels Aug 30, 2020
efiop added a commit to efiop/dvc that referenced this issue Aug 30, 2020
efiop added a commit that referenced this issue Aug 30, 2020
* dvc: dont catch generic exceptions

* dvc: show "Having any troubles?" only on unexpected errors

Fixes #4126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC help wanted p1-important Important, aka current backlog of things to do ui user interface / interaction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants