Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get/import: progress bar is broken #3874

Closed
skshetry opened this issue May 26, 2020 · 0 comments · Fixed by #4039
Closed

get/import: progress bar is broken #3874

skshetry opened this issue May 26, 2020 · 0 comments · Fixed by #4039
Assignees
@skshetry
Labels
p1-important Important, aka current backlog of things to do research ui user interface / interaction

Comments

@skshetry
Copy link
Member

We broke the progress bar for the get/import. It is now Downloading 0/1 files vs Downloading 0/36.2M before. Mean that we effectively don't show a progress bar for the case like:

dvc get https://github.com/iterative/dataset-registry get-started/data.xml -o data/data.xml

Originally posted by @shcheklein in #3777
@skshetry skshetry added the ui user interface / interaction label May 26, 2020
@shcheklein shcheklein mentioned this issue May 26, 2020
Closed
15 tasks
@efiop efiop added the p1-important Important, aka current backlog of things to do label May 26, 2020
@efiop efiop added the research label May 26, 2020
skshetry added a commit to skshetry/dvc that referenced this issue Jun 14, 2020
@skshetry
(bugfix) get/import: fix broken progress bar
95f7bd8 
PR iterative#3672 (6d8499e) extended `LocalRemote::_get_plans` to return one
`checksums` too. As all of the args from `_get_plans` was passed
down to `download()`, it recognized extra arg of checksum as
`no_progress_bar` due to which it became True and stopped showing
progress bar at all.

Fix iterative#3874
@skshetry skshetry mentioned this issue Jun 14, 2020
Merged
3 tasks
efiop pushed a commit that referenced this issue Jun 14, 2020
@skshetry
(bugfix) get/import: fix broken progress bar (#4039)
bc4bf66 
PR #3672 (6d8499e) extended `LocalRemote::_get_plans` to return one
`checksums` too. As all of the args from `_get_plans` was passed
down to `download()`, it recognized extra arg of checksum as
`no_progress_bar` due to which it became True and stopped showing
progress bar at all.

Fix #3874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skshetry skshetry

Labels
p1-important Important, aka current backlog of things to do research ui user interface / interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(bugfix) get/import: fix broken progress bar skshetry/dvc
2 participants
@efiop @skshetry