Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull output is not informative and too massive #1840

Closed
shcheklein opened this issue Apr 6, 2019 · 5 comments
Closed

pull output is not informative and too massive #1840

shcheklein opened this issue Apr 6, 2019 · 5 comments
Assignees
Labels
enhancement Enhances DVC p2-medium Medium priority, should be done, but less important ui user interface / interaction

Comments

@shcheklein
Copy link
Member

If I have a few directories it's hard to understand what's going on:

[##############################] 100% Collecting information
[##############################] 100% Analysing status.
[##############################] 100% data/features
Preparing to download data from 'https://remote.dvc.org/get-started'
Preparing to collect status from https://remote.dvc.org/get-started
[##############################] 100% Collecting information
[##############################] 100% Analysing status.
[##############################] 100% data/prepared
Preparing to download data from 'https://remote.dvc.org/get-started'
Preparing to collect status from https://remote.dvc.org/get-started
[##############################] 100% Collecting information
[##############################] 100% Analysing status.

It feels like it's printing the same thing over and over again. It's confusing, I was even though for a moment that this is a bug.

@efiop efiop added enhancement Enhances DVC p2-medium Medium priority, should be done, but less important labels Apr 6, 2019
@efiop
Copy link
Contributor

efiop commented Apr 6, 2019

@shcheklein That first part is from where it tries to pull missing dir cache during used cache collection. Need to make it more clear, and, probably optimize it so it doesn't download those files one-by-one during cache collection.

@ghost ghost added the ui user interface / interaction label Apr 6, 2019
@shcheklein
Copy link
Member Author

@efiop @casperdcl is this one resolved? In the current version I actually see something happening (Multi-threaded messages or something like this blinking), then progress bars that show download process and then nothing. I think we cut everything too aggressively, Multi-threaded is not important enough to emphasize (some message like "Downloading data" should be emphasized). At the end I would keep at least a list of what has been done, may be show a list of files directories with some basic stats - removed/added - similar to what Git is doing.

@efiop
Copy link
Contributor

efiop commented Sep 4, 2019

@shcheklein We've cut some stuff out as a part of initial migration, and a more in-depth reconsideration will be coming later. @casperdcl added assignee to better track this one 🙂

The original issue is caused by two-step pull, where dvc is first pulling .dir cache file to know which files it needs to download later. And that one is still there, but the tqdm migration made it much more bearable. We would want to closer look into this one later.

@efiop
Copy link
Contributor

efiop commented Nov 11, 2019

For the record: When pulling/pushing large number of fairly small files, you see N progress bars flickering in and out of the existence(which is understandable as push/pull takes a short time). Need to come up with a better way of displaying the progress.

casperdcl added a commit to casperdcl/dvc that referenced this issue Apr 5, 2020
@casperdcl casperdcl mentioned this issue Apr 5, 2020
3 tasks
@casperdcl
Copy link
Contributor

casperdcl commented Apr 25, 2020

Think this can be closed as it was fixed by clearing away progress bars upon completion. Actually currently might not be informative enough.
#1838 seems more appropriate. @shcheklein?

efiop added a commit that referenced this issue Apr 25, 2020
* progress: add main push/pull bar

Fixes #3452
Related #1840
Related #3565

* adjust desc

* fix merge

Co-authored-by: Ruslan Kuprieiev <[email protected]>
Co-authored-by: Ruslan Kuprieiev <[email protected]>
@efiop efiop closed this as completed Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC p2-medium Medium priority, should be done, but less important ui user interface / interaction
Projects
None yet
Development

No branches or pull requests

3 participants