-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: regular updates (mid Jan) #915
Conversation
and other improvements near the changed text per #914 (review)
2ad1255
to
c88d436
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go, just a few comments. thanks 🎉
import ReactMarkdown from 'react-markdown' | ||
import { LightButton } from '../LightButton' | ||
import Tutorials from '../Tutorials' | ||
import Tooltip from '../../Tooltip' | ||
import Collapsible from 'react-collapsible' | ||
// syntax highlighter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here - let's not do this right now. Let's postpone cosmetic JS changes please and wait for @iAdramelk to wrap up the two major branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean not to remove those unnecessary comments? I thought we agreed to remove them. Should I bring them back? Up to you, but I think a simple removal like this is very unlikely to produce merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I mean not do a lot of cosmetic changes to JS at this moment. We can do it later. It might create conflicts for @iAdramelk for no good reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK... Reverted https://github.com/iterative/dvc.org/compare/4950d25..7ea2edb in c64d590. This is the 2nd time these changes get reverted so I'll just forget about this until/if someone else brings it up 😋
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check a few comments - otherwise looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 good stuff
Misc. stuff +