Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdrive: Shared drives support #914

Merged
merged 1 commit into from
Jan 12, 2020
Merged

gdrive: Shared drives support #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions public/static/docs/command-reference/remote/add.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,24 @@ On successful access token generation, token data will be cached in git ignored
directory with path `.dvc/tmp/gdrive-user-credentials.json`. Do not share token
data with anyone else to prevent unauthorized access to your Google Drive.

#### Shared drives support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about adding subheaders in hidden sections. We don't even have H4s anywyere yet, this would be the first one in all the docs actually (except for 2 wrong ones I just noticed in dvc version which I'll fix soon). The anchor icon is not displayed properly:
image
and if you try to use the direct link (https://dvc.org/doc/command-reference/remote/add#shared-drives-support) the page won't open the section and scroll to that header.

Copy link
Contributor

@jorgeorpinel jorgeorpinel Jan 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I just found another one in this same doc actually, inside the Aliyun OSS section.

Anyway, since this is merged I'll just come up with a better solution in a near-future "regular updates" PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeorpinel yep, we can change it to a regular bold

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK addressed. Feel free to review: 26d9928 Thanks


You need to obtain `id` of your shared drive directory to use it as part of URL
passed to DVC. `id` can be found in your web browser address bar when shared
drive is opened. For example, for the URL

```dvc
https://drive.google.com/drive/folders/0AIac4JZqHhKmUk9PDA
```

the `id` will be equal to `0AIac4JZqHhKmUk9PDA`.

Use obtained `id` in remote's URL:

```dvc
$ dvc remote add myremote gdrive://0AIac4JZqHhKmUk9PDA/my-dvc-root
```

</details>

<details>
Expand Down