Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdrive support #833
gdrive support #833
Changes from all commits
2c540fc
0bec1d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Continuation of #833 (review)
But is it DVC's responsibility to alert about G Drive security? If not, maybe just a note (md quote starting with
>
) will suffice after all @shcheklein?Regardless, please use this text:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good to have this for GD - it not a common knowledge with all these tokens involved into GD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quotes with
>
are not visible. they defeat the purpose to some extent for notes like this. I'm fine with>
though. I don't like when we mix>
with some Note! or something -they look not very clean to me.But tbh - I'm fine with all of these option. Jorge, I think we'll let you decide on this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree notes with
>
are not visible and perhaps we shouldn't mix with bold "Note!". That's kind of contradictory! Opened #848 for this.in this case though, while I like having the note, I do see it as a side-note that could be completely omitted and not something that DVC can really control. So for that reason and since we don't really have emojis ATM, I'm going to take it back to a
>
note...Should we open an issue to apply some basic emoji symbols throughout with some consistency though? This could be a nice improvement to our docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in d9ab97f