Add docs about pager in the pipeline command #831

ghost · 2019-12-02T19:58:28Z

Fixes #836

static/docs/command-reference/pipeline/show.md

static/docs/user-guide/running-dvc-on-windows.md

static/docs/command-reference/pipeline/show.md

static/docs/user-guide/running-dvc-on-windows.md

shcheklein

Good stuff!

There are other places that explain navigation by W, A, etc - please do git grep

Also, check some comments I left.

1. add dvc or bash to code blocks 2. remove a reference of WASD 3. replace a code comment with a paragraph

ghost · 2019-12-09T21:17:40Z

@xliiv build is failing, pre-commit is not installed? check the docs contributing guide, please to install it

I installed it yesterday.. i'm not sure why the invalid commit passed.. .
Maybe it's related to vim's fugitive where i do commits?

shcheklein

👍

static/docs/command-reference/pipeline/show.md

jorgeorpinel

Some specific notes below. Please also spell check all your changes (I fixed a few typos).

static/docs/command-reference/pipeline/show.md

static/docs/user-guide/running-dvc-on-windows.md

ghost · 2019-12-11T19:55:58Z

Some specific notes below. Please also spell check all your changes (I fixed a few typos).

good catch, checked and fixed two words.. 👍

static/docs/command-reference/pipeline/show.md

static/docs/user-guide/running-dvc-on-windows.md

jorgeorpinel

Almost there. Thanks!

static/docs/command-reference/pipeline/show.md

static/docs/user-guide/running-dvc-on-windows.md

static/docs/command-reference/pipeline/show.md

static/docs/user-guide/running-dvc-on-windows.md

jorgeorpinel

Last details I think

static/docs/user-guide/running-dvc-on-windows.md

jorgeorpinel

Shoot sorry, one last detail ^

jorgeorpinel · 2019-12-11T23:04:04Z

static/docs/user-guide/running-dvc-on-windows.md

+```
+
+`less` can be installed in other ways, just make sure it's available in
+`cmd`/Powershell, where you run dvc. (This usually means adding the directory


Suggested change

`cmd`/Powershell, where you run dvc. (This usually means adding the directory

`cmd`/Powershell, where you run `dvc`. (This usually means adding the directory

Actually I can commit this 🙂 One min...

Ah no, sorry. I don't have permission to push to your fork. Please

(p.s. FYI you can allow upstream repo maintainers to push to the branch in the PR settings.)

@jorgeorpinel let's merge and fix it in-place? :) it's too minor to do a cycle.

True, I can definitely do that!

Fixed in 9955833.

jorgeorpinel · 2019-12-11T23:28:32Z

Thanks for the contribution and addressing all the feedback so promptly @xliiv !

per #831 (comment)

ghost · 2019-12-12T08:39:03Z

Thanks for the contribution and addressing all the feedback so promptly @xliiv !

thank you for your review!

Add docs about pager in the pipeline command

a3b076c

ghost mentioned this pull request Dec 2, 2019

dvc/dagascii: Use pager instead of AsciiCanvas._do_draw iterative/dvc#2815

Merged

3 tasks

This comment has been minimized.

Sign in to view

shcheklein reviewed Dec 2, 2019

View reviewed changes

static/docs/command-reference/pipeline/show.md Outdated Show resolved Hide resolved

weekly-digest bot mentioned this pull request Dec 8, 2019

Weekly Digest (1 December, 2019 - 8 December, 2019) #842

Closed

Tymoteusz Jankowski added 3 commits December 8, 2019 14:14

Add a section how to install pager on Windows

623c38c

Wrap the pager content in pipeline show with a sub-section

acaaf05

Add info about less tool arguments in pipeline show

54f4b5a

This comment has been minimized.

Sign in to view

Move the Paging the output section before the examples

382b9d9

ghost marked this pull request as ready for review December 8, 2019 13:28

Run yarn prettier --write .. for changed files

138a362

ghost changed the title ~~Add docs about pager in the pipeline command~~ WIP Add docs about pager in the pipeline command Dec 8, 2019

Fix the enabling pager link in pipeline show

4ef90d1

ghost changed the title ~~WIP Add docs about pager in the pipeline command~~ Add docs about pager in the pipeline command Dec 8, 2019

shcheklein reviewed Dec 9, 2019

View reviewed changes

static/docs/command-reference/pipeline/show.md Outdated Show resolved Hide resolved

shcheklein reviewed Dec 9, 2019

View reviewed changes

static/docs/command-reference/pipeline/show.md Outdated Show resolved Hide resolved

shcheklein reviewed Dec 9, 2019

View reviewed changes

static/docs/command-reference/pipeline/show.md Show resolved Hide resolved

shcheklein reviewed Dec 9, 2019

View reviewed changes

static/docs/command-reference/pipeline/show.md Outdated Show resolved Hide resolved

shcheklein reviewed Dec 9, 2019

View reviewed changes

static/docs/command-reference/pipeline/show.md Show resolved Hide resolved

shcheklein reviewed Dec 9, 2019

View reviewed changes

static/docs/user-guide/running-dvc-on-windows.md Outdated Show resolved Hide resolved

shcheklein reviewed Dec 9, 2019

View reviewed changes

static/docs/command-reference/pipeline/show.md Outdated Show resolved Hide resolved

shcheklein reviewed Dec 9, 2019

View reviewed changes

static/docs/user-guide/running-dvc-on-windows.md Outdated Show resolved Hide resolved

shcheklein requested changes Dec 9, 2019

View reviewed changes

shcheklein requested a review from jorgeorpinel December 9, 2019 00:24

Tymoteusz Jankowski added 3 commits December 9, 2019 20:57

Small updates

93409de

1. add dvc or bash to code blocks 2. remove a reference of WASD 3. replace a code comment with a paragraph

Link the paging the output section in options and example

1c2a6a0

Add $ to code snippets

4ab3b3c

shcheklein temporarily deployed to dvc-landing-2807-use-pa-emgsrg December 9, 2019 20:26 Inactive

Add a sub-section about custom pager on Windows page

3e27e1b

shcheklein temporarily deployed to dvc-landing-2807-use-pa-emgsrg December 9, 2019 21:12 Inactive

This comment has been minimized.

Sign in to view

shcheklein approved these changes Dec 9, 2019

View reviewed changes

jorgeorpinel reviewed Dec 10, 2019

View reviewed changes

jorgeorpinel suggested changes Dec 10, 2019

View reviewed changes

Apply code review comments

79ae400

shcheklein temporarily deployed to dvc-landing-2807-use-pa-emgsrg December 11, 2019 19:43 Inactive

shcheklein requested a review from jorgeorpinel December 11, 2019 19:44

Fix typos

7fc8127

shcheklein temporarily deployed to dvc-landing-2807-use-pa-emgsrg December 11, 2019 19:55 Inactive

jorgeorpinel reviewed Dec 11, 2019

View reviewed changes

static/docs/command-reference/pipeline/show.md Outdated Show resolved Hide resolved

static/docs/user-guide/running-dvc-on-windows.md Outdated Show resolved Hide resolved

jorgeorpinel suggested changes Dec 11, 2019

View reviewed changes

Remove custom pager section and 2 redundant lines

40e7888

shcheklein temporarily deployed to dvc-landing-2807-use-pa-emgsrg December 11, 2019 20:29 Inactive

jorgeorpinel reviewed Dec 11, 2019

View reviewed changes

static/docs/command-reference/pipeline/show.md Outdated Show resolved Hide resolved

static/docs/user-guide/running-dvc-on-windows.md Outdated Show resolved Hide resolved

jorgeorpinel reviewed Dec 11, 2019

View reviewed changes

Update the link in --ascii option in pipline command

53e4c8d

shcheklein temporarily deployed to dvc-landing-2807-use-pa-emgsrg December 11, 2019 20:39 Inactive

jorgeorpinel suggested changes Dec 11, 2019

View reviewed changes

static/docs/user-guide/running-dvc-on-windows.md Outdated Show resolved Hide resolved

More review updates

3441f79

shcheklein temporarily deployed to dvc-landing-2807-use-pa-emgsrg December 11, 2019 20:58 Inactive

jorgeorpinel suggested changes Dec 11, 2019

View reviewed changes

jorgeorpinel approved these changes Dec 11, 2019

View reviewed changes

shcheklein merged commit 917be5a into iterative:master Dec 11, 2019

jorgeorpinel added a commit that referenced this pull request Dec 11, 2019

back ticks for dvc and H for "GitHub"

9955833

per #831 (comment)

weekly-digest bot mentioned this pull request Dec 15, 2019

Weekly Digest (8 December, 2019 - 15 December, 2019) #865

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add docs about pager in the pipeline command #831

Add docs about pager in the pipeline command #831

ghost commented Dec 2, 2019 •

edited by ghost

Loading

This comment has been minimized.

This comment has been minimized.

shcheklein left a comment

This comment has been minimized.

ghost commented Dec 9, 2019

shcheklein left a comment

jorgeorpinel left a comment

ghost commented Dec 11, 2019

jorgeorpinel left a comment

jorgeorpinel left a comment

jorgeorpinel left a comment

jorgeorpinel Dec 11, 2019

jorgeorpinel Dec 11, 2019

jorgeorpinel Dec 11, 2019

jorgeorpinel Dec 11, 2019

shcheklein Dec 11, 2019

jorgeorpinel Dec 11, 2019

jorgeorpinel Dec 11, 2019

jorgeorpinel commented Dec 11, 2019

ghost commented Dec 12, 2019

	`cmd`/Powershell, where you run dvc. (This usually means adding the directory
	`cmd`/Powershell, where you run `dvc`. (This usually means adding the directory

Add docs about pager in the pipeline command #831

Add docs about pager in the pipeline command #831

Conversation

ghost commented Dec 2, 2019 • edited by ghost Loading

This comment has been minimized.

This comment has been minimized.

shcheklein left a comment

Choose a reason for hiding this comment

This comment has been minimized.

ghost commented Dec 9, 2019

shcheklein left a comment

Choose a reason for hiding this comment

jorgeorpinel left a comment

Choose a reason for hiding this comment

ghost commented Dec 11, 2019

jorgeorpinel left a comment

Choose a reason for hiding this comment

jorgeorpinel left a comment

Choose a reason for hiding this comment

jorgeorpinel left a comment

Choose a reason for hiding this comment

jorgeorpinel Dec 11, 2019

Choose a reason for hiding this comment

jorgeorpinel Dec 11, 2019

Choose a reason for hiding this comment

jorgeorpinel Dec 11, 2019

Choose a reason for hiding this comment

jorgeorpinel Dec 11, 2019

Choose a reason for hiding this comment

shcheklein Dec 11, 2019

Choose a reason for hiding this comment

jorgeorpinel Dec 11, 2019

Choose a reason for hiding this comment

jorgeorpinel Dec 11, 2019

Choose a reason for hiding this comment

jorgeorpinel commented Dec 11, 2019

ghost commented Dec 12, 2019

ghost commented Dec 2, 2019 •

edited by ghost

Loading