-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix: refactor man.dvc.org redirect again and add try to force no-cache #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgeorpinel
commented
Nov 4, 2019
jorgeorpinel
commented
Nov 4, 2019
jorgeorpinel
changed the title
hotfix: refactor man.dvc.org redirect again...
hotfix: refactor man.dvc.org redirect again [WIP]
Nov 4, 2019
This reverts commit 5d28ce4.
jorgeorpinel
requested review from
iAdramelk
and removed request for
iAdramelk
November 4, 2019 17:13
@jorgeorpinel merge this? |
jorgeorpinel
changed the title
hotfix: refactor man.dvc.org redirect again [WIP]
hotfix: refactor man.dvc.org redirect again and add try to force no-cache
Nov 4, 2019
jorgeorpinel
commented
Nov 4, 2019
Comment on lines
+37
to
+38
'Cache-Control': 'no-cache', | ||
Location: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added no-cache, let's merge and see what this does @shcheklein...
shcheklein
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time reduced code as much as possible, reintroduced ternary operator...
For #768