-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #bugnum: 760 Use requirements.txt for dvc requirement. Add requirements.txt to src… #761
Fix #bugnum: 760 Use requirements.txt for dvc requirement. Add requirements.txt to src… #761
Conversation
…/. Update docs to relfect.
@welenofsky basically though your changes are appropriate we ended up moving in a different direction as you can see in b7ad28f. Sorry!
This would actually be really helpful if you could help us with. I didn't see it in the changes of this PR though. Basically you would revert all your previous changes (sorry again) or just open a new PR and add notes similar to the one you can see in the link I added above, but for the Get Started index or any other docs you find that it maybe useful other than tutorials (which I've done) and Get Started (which you would do). Lmk, I can also do this myself later if not but we love interacting with contributors! 🙂 |
@jorgeorpinel Can do. Will jump on in a few hours when I get home. Do you want me to just say something along the lines of "Note: these tutorials require |
Awesome! I used |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sorry about the lag. I have updated the get-started index.md with the git instructions you requested. I have reverted the changes to all other markdown files as requested as well. Thanks for letting me help/PR this. I appreciate it. |
@jorgeorpinel is it good to merge? |
Yes. Sorry for the delay on my part. |
p.s. this will be further modified with #747 BTW. Just a note. |
Thanks @welenofsky ! |
This resolves #760
Note: I
did not find a existing requirements.txt inside the repo. I noticed the docs mentioning src/requirements.txt so I placed the new requirements.txt there. If this was a mistake let me know. I alsoremoved the references to manually installing DVC as suggested. I then added a note to the getting started index.md telling users this guide requires git, with a link to git-scm.org to download