Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #bugnum: 760 Use requirements.txt for dvc requirement. Add requirements.txt to src… #761

Merged
merged 4 commits into from
Nov 8, 2019
Merged

Fix #bugnum: 760 Use requirements.txt for dvc requirement. Add requirements.txt to src… #761

merged 4 commits into from
Nov 8, 2019

Conversation

welenofsky
Copy link
Contributor

@welenofsky welenofsky commented Oct 31, 2019

This resolves #760

Note: I did not find a existing requirements.txt inside the repo. I noticed the docs mentioning src/requirements.txt so I placed the new requirements.txt there. If this was a mistake let me know. I also removed the references to manually installing DVC as suggested. I then added a note to the getting started index.md telling users this guide requires git, with a link to git-scm.org to download

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 31, 2019

@welenofsky basically though your changes are appropriate we ended up moving in a different direction as you can see in b7ad28f. Sorry!

...then added a note to the getting started index.md telling users this guide requires git, with a link to git-scm.org to download.

This would actually be really helpful if you could help us with. I didn't see it in the changes of this PR though. Basically you would revert all your previous changes (sorry again) or just open a new PR and add notes similar to the one you can see in the link I added above, but for the Get Started index or any other docs you find that it maybe useful other than tutorials (which I've done) and Get Started (which you would do).

Lmk, I can also do this myself later if not but we love interacting with contributors! 🙂

@welenofsky
Copy link
Contributor Author

@jorgeorpinel Can do. Will jump on in a few hours when I get home. Do you want me to just say something along the lines of "Note: these tutorials require git. If you do not have git installed you may download it from https://git-scm.com" ?

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Nov 1, 2019

Awesome! I used You'll need [Git](https://git-scm.com) to run the commands in this tutorial. in my changes to tutorials. Feel free to check them out: b7ad28f

@shcheklein

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

@welenofsky
Copy link
Contributor Author

Sorry about the lag. I have updated the get-started index.md with the git instructions you requested. I have reverted the changes to all other markdown files as requested as well. Thanks for letting me help/PR this. I appreciate it.

@shcheklein
Copy link
Member

@jorgeorpinel is it good to merge?

@jorgeorpinel
Copy link
Contributor

Yes. Sorry for the delay on my part.

@jorgeorpinel
Copy link
Contributor

p.s. this will be further modified with #747 BTW. Just a note.

@shcheklein shcheklein merged commit b9c1357 into iterative:master Nov 8, 2019
@shcheklein
Copy link
Member

Thanks @welenofsky !

@welenofsky welenofsky deleted the doc-update-dvc-requirement-txt branch November 8, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tutorials: install DVC as pip requirement?
3 participants