Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hydra: plugins_path and advanced config #5097

Merged
merged 5 commits into from
Feb 2, 2024
Merged

hydra: plugins_path and advanced config #5097

merged 5 commits into from
Feb 2, 2024

Conversation

dberenbaum
Copy link
Contributor

@dberenbaum dberenbaum commented Jan 31, 2024

Partially addresses two different issues:

@shcheklein shcheklein temporarily deployed to dvc-org-hydra-plugins-one6i2dd January 31, 2024 22:46 Inactive
Copy link
Contributor

github-actions bot commented Jan 31, 2024

Link Check Report

There were no links to check!

@dberenbaum dberenbaum marked this pull request as ready for review February 1, 2024 15:46
@dberenbaum
Copy link
Contributor Author

@AlexandreKempf It would be great to get your help with some of the docs issues. PTAL and let me know if you have thoughts or questions.

@dberenbaum dberenbaum requested a review from shcheklein February 1, 2024 15:47

[config composition]:
https://hydra.cc/docs/tutorials/basic/your_first_app/composition/
[config groups]:
https://hydra.cc/docs/tutorials/basic/your_first_app/config_groups/
[defaults list]: https://hydra.cc/docs/tutorials/basic/your_first_app/defaults/
[config module]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it referenced anywhere? just to double check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch on this one.

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few things to double check / cleanup. Thanks @dberenbaum !

@shcheklein shcheklein temporarily deployed to dvc-org-hydra-plugins-one6i2dd February 1, 2024 16:30 Inactive
Copy link
Contributor

@AlexandreKempf AlexandreKempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% familiar with the subject (I have used hydra and DVC, but never together). Your additional doc looks clear on how to use them together. Maybe one or two concerns before I approve it 😃

@dberenbaum dberenbaum enabled auto-merge (squash) February 2, 2024 14:37
@shcheklein shcheklein temporarily deployed to dvc-org-hydra-plugins-one6i2dd February 2, 2024 14:38 Inactive
@dberenbaum dberenbaum merged commit 881165d into main Feb 2, 2024
3 checks passed
@dberenbaum dberenbaum deleted the hydra-plugins branch February 2, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants