-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hydra: plugins_path and advanced config #5097
Conversation
@AlexandreKempf It would be great to get your help with some of the docs issues. PTAL and let me know if you have thoughts or questions. |
|
||
[config composition]: | ||
https://hydra.cc/docs/tutorials/basic/your_first_app/composition/ | ||
[config groups]: | ||
https://hydra.cc/docs/tutorials/basic/your_first_app/config_groups/ | ||
[defaults list]: https://hydra.cc/docs/tutorials/basic/your_first_app/defaults/ | ||
[config module]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it referenced anywhere? just to double check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few things to double check / cleanup. Thanks @dberenbaum !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% familiar with the subject (I have used hydra and DVC, but never together). Your additional doc looks clear on how to use them together. Maybe one or two concerns before I approve it 😃
Partially addresses two different issues: