Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address feedback #5036

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Address feedback #5036

merged 7 commits into from
Dec 7, 2023

Conversation

yathomasi
Copy link
Contributor

@yathomasi yathomasi commented Dec 6, 2023

This pull request includes the following changes:

  • Optimized spacing to fit the homepage to desktop screens

  • Hidden the alert banner

  • Removed CML from the footer and menu

  • Added a simple loading effect to GitHub stars

  • Updated "Studio" to "DVC Studio" in the footer and menu

  • Renamed "dql" to "dvcx"

  • Closes Improve UI: feedback after #4737 #5031

TODO:

Preview: cc: @jendefig
Screenshot 2023-12-06 at 21 44 22

@yathomasi yathomasi requested a review from a team as a code owner December 6, 2023 15:24
@yathomasi yathomasi self-assigned this Dec 6, 2023
@shcheklein shcheklein temporarily deployed to dvc-org-address-website-9kzcr8 December 6, 2023 15:26 Inactive
Copy link
Contributor

github-actions bot commented Dec 6, 2023

Link Check Report

There were no links to check!

@yathomasi yathomasi temporarily deployed to dvc-org-address-website-9kzcr8 December 7, 2023 07:20 Inactive
@yathomasi yathomasi merged commit e132c09 into main Dec 7, 2023
4 checks passed
@yathomasi yathomasi deleted the address-website-feedback branch December 7, 2023 07:36
@skshetry
Copy link
Member

skshetry commented Dec 7, 2023

Is "What's new?" button important? Would be nice if we could get rid of it as well. 😄

@jendefig
Copy link
Contributor

jendefig commented Dec 7, 2023

It looks much better @yathomasi! 🙏 It's still cut off, but you can definitely see more.

@skshetry The "What's new" button is important it gets people to the latest on the blog, though we need more regular content as discussed this morning.

One thing I don't understand is why the page leads with DVCx right now. I think ultimately this makes sense at the release, but right now it's kind of odd and feels sell-y for the dvc.org website (even though it shows the open-source version, I'm speaking about the driving to waitlist part). It would make more sense to include it at the end after what was there before. But I guess we are not talking about much time in this state theoretically. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UI: feedback after #4737
4 participants