Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: move gdrive #4357

Merged
merged 3 commits into from
Mar 3, 2023
Merged

guide: move gdrive #4357

merged 3 commits into from
Mar 3, 2023

Conversation

dberenbaum
Copy link
Contributor

Migrates Google Drive guide and command ref info to new guide section. No substantive changes. Part of #2866

@dberenbaum dberenbaum requested a review from shcheklein March 3, 2023 19:44
@shcheklein shcheklein temporarily deployed to dvc-org-gdrive-yitwbbgfzahgn5f March 3, 2023 19:47 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Link Check Report

There were no links to check!

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dberenbaum ! Do we need to update redirects by chance?

@@ -47,6 +25,29 @@ Authentication successful.

See [Authorization](#authorization) for more details.

Note that GDrive remotes are not "trusted" by default. This means that the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like a very advanced detail tbh to start the page ... can we move it a bit somehwere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where else to put it, so put it into a details section for now to hide it better.

@@ -322,3 +322,120 @@ The remote must also be configured with the associated user **personal email**:
$ dvc remote modify myremote gdrive_service_account_user_email \
example_adress@some_google_domain.com
```

## Configuration parameters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put a link at the very top - like "TL;DR: - here is the list of all config options"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added near the top.

@dberenbaum dberenbaum requested a review from a team as a code owner March 3, 2023 21:53
@shcheklein shcheklein had a problem deploying to dvc-org-gdrive-yitwbbgfzahgn5f March 3, 2023 21:53 Failure
@dberenbaum
Copy link
Contributor Author

Thanks @dberenbaum ! Do we need to update redirects by chance?

Good catch. Added for https://dvc.org/doc/user-guide/how-to/setup-google-drive-remote. I don't think we need any others since we still have the cmd ref pages and they link to these guides.

@shcheklein
Copy link
Member

There is some failure in deployment though. Need to check it first or please try to run locally.

@dberenbaum
Copy link
Contributor Author

🤔 Deployment is working for me locally

@shcheklein shcheklein temporarily deployed to dvc-org-gdrive-yitwbbgfzahgn5f March 3, 2023 22:41 Inactive
@shcheklein
Copy link
Member

I've fixed the deployment. Merging this, let's please rebase / merge main into the other branches after that.

@shcheklein shcheklein merged commit 9ab9256 into main Mar 3, 2023
@shcheklein shcheklein deleted the gdrive branch March 3, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants