Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: new Overview page #4006

Merged
merged 9 commits into from
Sep 29, 2022
Merged

guide: new Overview page #4006

merged 9 commits into from
Sep 29, 2022

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Sep 29, 2022

OP

Per #144 (comment):

  • Index page: remove?
  • What is DVC: dissolve into some page outside the user guide (and maybe in the home page/outside of docs).

Note that clicking the UG nav entry will now open directly in https://dvc.org/doc/user-guide/project-structure (for now).

UPDATE:

Per #144 (comment):

turn it into an Overview instead, which would combine its existing Core Features section as well as Related Technologies (which also addresses "Related Technologies: dissolve into some page" from the OP).

  • Also moves/reinforces other sections of What is DVC? in other existing docs.
  • Updates links and redirects accordingly .

In review app: https://dvc-org-guide-break-up--bvcwlb.herokuapp.com/doc/user-guide

(the latter from sidebar only for now)
@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide labels Sep 29, 2022
@jorgeorpinel jorgeorpinel self-assigned this Sep 29, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-guide-break-up--bvcwlb September 29, 2022 00:37 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-guide-break-up--bvcwlb September 29, 2022 00:46 Inactive
@jorgeorpinel jorgeorpinel added the p1-important Active priorities to deal within next sprints label Sep 29, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2022

0aa5585

Link Check Report

There were no links to check!

CML watermark

@shcheklein shcheklein temporarily deployed to dvc-org-guide-break-up--bvcwlb September 29, 2022 02:32 Inactive
Comment on lines -12 to -14
Data science experiment sharing and collaboration can be done through a regular
Git flow (commits, branching, pull requests, etc.), the same way it works for
software engineers. Using Git and DVC, data science and machine learning teams
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this is already mentioned in the docs home and Exp Mgmt docs so I'm just removing it.

@jorgeorpinel jorgeorpinel changed the title guide: remove index page and What is DVC? guide: remove index page and What is DVC Sep 29, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-guide-break-up--bvcwlb September 29, 2022 02:35 Inactive
and remove Core Features header (tmp)y
@shcheklein shcheklein temporarily deployed to dvc-org-guide-break-up--bvcwlb September 29, 2022 02:39 Inactive
@jorgeorpinel

This comment was marked as outdated.

@shcheklein shcheklein temporarily deployed to dvc-org-guide-break-up--bvcwlb September 29, 2022 03:21 Inactive
@jorgeorpinel jorgeorpinel removed the request for review from dberenbaum September 29, 2022 03:43
@jorgeorpinel
Copy link
Contributor Author

UPDATE: Actually, per #144 (comment) I'm going to transform the Core Features section of What is DVC? as well as the Related Technologies page into an overview for the UG. For now it will be the first sub-page (no index page) but it could also be the index page itself. WDYT @dberenbaum ?

@shcheklein shcheklein temporarily deployed to dvc-org-guide-break-up--bvcwlb September 29, 2022 03:46 Inactive
@jorgeorpinel jorgeorpinel changed the title guide: remove index page and What is DVC guide: replace What is DVC and Related Technologies with Overview (and other sections) Sep 29, 2022
@jorgeorpinel jorgeorpinel marked this pull request as ready for review September 29, 2022 16:58
@jorgeorpinel jorgeorpinel changed the title guide: replace What is DVC and Related Technologies with Overview (and other sections) guide: new Overview page Sep 29, 2022
Comment on lines -97 to +99
"source": "user-guide/index.md",
"source": false,
"children": [
{
"label": "What is DVC?",
"slug": "what-is-dvc"
},
"overview",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we use the UG index page for Overview? No strong opinion

Comment on lines +61 to +62
"^/doc/user-guide/what-is-dvc$ /doc/user-guide/overview 302",
"^/doc/user-guide/related-technologies$ /doc/user-guide/overview 302",
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Sep 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

302s for now in case we later decide to move it to the UG index page instead, though

Comment on lines +67 to +74
## Comparison with Related Technologies

DVC combines a number of existing ideas into a single tool, with the goal of
bringing best practices from software engineering into the data science field
(refer to [What is DVC?](/doc/user-guide/what-is-dvc) for more details).
bringing best practices from software engineering into the data science field.

<details>

## Git
### Git
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is moved verbatim for now. I just put each technology into collapsed sections so the Overview page stays short (on the surface at least).

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It goes in the right direction, I think .. we can do structural changes like this quick and iterate on the content later

@jorgeorpinel
Copy link
Contributor Author

Sounds good! There's a separate task to combine Core Features and Feature pages (both rel #144 (comment) and #3833) so I suppose we can merge this indeed 🙂

@shcheklein shcheklein temporarily deployed to dvc-org-guide-break-up--bvcwlb September 29, 2022 18:22 Inactive
Comment on lines -56 to -68
## DVC does not replace Git!

DVC files such as `dvc.yaml` and `.dvc` files serve as placeholders to track
large data files and directories for versioning (among other
[purposes](/doc/user-guide/project-structure)). These metafiles change along
with your data, and you can use Git to place them under
[version control](https://git-scm.com/book/en/v2/Getting-Started-About-Version-Control)
as a proxy to the actual data versions, which are stored in the <abbr>DVC
cache</abbr> (outside of Git). This does not replace features of Git.

DVC does, however, provide several commands similar to Git such as `dvc init`,
`dvc add`, `dvc checkout`, or `dvc push`, which interact with the underlying Git
repo (if one is being used, which is not required).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been fully removed although the point has also been stressed in other existing docs but I'm not sure it's mentioned everywhere it should -- so that's another possible minor follow-up to this.

@jorgeorpinel jorgeorpinel merged commit 0aa5585 into main Sep 29, 2022
@jorgeorpinel jorgeorpinel deleted the guide/break-up-intro branch September 29, 2022 18:24
@jorgeorpinel
Copy link
Contributor Author

Cc @dberenbaum just FYI on this change (review no longer needed but if there's any feedback feel free to leave it).

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Oct 4, 2022

UG Overview page deployed ⚓

Note that Studio docs have a similar page called How it works, so this may be a bit of a pattern to keep in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: guide Content of /doc/user-guide p1-important Active priorities to deal within next sprints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants