-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: document dvc queue
#3715
ref: document dvc queue
#3715
Conversation
@pmrowla Is this ready for review? |
Everything that's pushed can be reviewed, but it still needs examples and the exp run changes |
> ⚠️ `dvc exp run --run-all [--jobs]` is now a shortcut for | ||
> `dvc queue start [--jobs]` followed by `dvc queue logs -f`. The `--run-all` | ||
> and `--jobs` options will likely be deprecated and removed in a future DVC | ||
> release. It is recommended to migrate your workflows to use | ||
> `dvc queue start` and `dvc queue logs`. Refer to the `dvc queue` | ||
> documentation for more details. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also include this kind of warning in core DVC (i.e. actually logging DeprecationWarning
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually yes, but there haven't been any formal decisions about what and what not to deprecate w/the queueing changes. I think the current plan is to not rush formally deprecating the existing experiments UI since the dvc queue
workflow will probably change once we get some user feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's fine to say that this will be deprecated (we are already doing it here). There shouldn't be a hard requirement to include deprecation of experiment features since they are "experimental" in 2.X, but it would be nice.
@dberenbaum @jorgeorpinel this is ready for review. I've added examples for |
4910e8e
to
e1930b4
Compare
@dberenbaum I can go ahead and continue making all of the suggested copy-edit type changes, but I was under the impression that this PR was going to be merged as-is and then further changes would be taken over by the docs team (and that these review issues were notes @jorgeorpinel was making for future reference) see: #3715 (comment) |
Okay, nothing blocking, so I'll merge as is. I hadn't seen any responses to some of the comments so wasn't sure what was happening. |
Product question - do we actually plan to deprecate anything related to "queued experiments" in the |
The deprecations in here are for My rationale:
|
@dberenbaum makes total sense. We can still probably expose queue to the experiments level in a different way? e.g. |
`--run-all` per #3715 (review)
* guide: update exp queue running examples per #3715 (review) * ref: move deprecation note from `exp run --jobs` to `--run-all` per #3715 (review) * ref: more context in queue index per #3715 (review) * queue: more descriptive start and parallel info rel. #3715 (review) * ref: updates to queue kill (et al) * ref: edits to queue stop * ref: edit queue remove * ref: edit queue status * ref: edit queue logs et al * guide: keep exp/queue commands per #3894 (comment) and #3894 (review) * guide: roll back typo per #3894 (review) * ref: update queue remove intro per #3894 (comment) * ref: roll back queue usage rel #3894 (review)
Initial command reference changes for
dvc queue
anddvc exp
Related to #3658
TODO:
dvc exp run
changes/deprecationsdvc queue
examples