-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: Using GCP remotes in DVC #3560
Conversation
Gatsby Cloud Build Reportdvc.org 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 3m PerformanceLighthouse report
|
Hey @julieg18! I'm a little confused by the error here. 😅 We don't have a |
Oh... Sorry about that! 😅 Let me know if you need anything from me! |
No worries! Pr is opened (#3604) and I requested your review. Though the websites team may approve it before you end up reading this :) |
@dberenbaum Would you mind approving this PR? Unless you see something else, we plan to publish this tomorrow. |
Thanks for pinging me @flippedcoder! Sorry for the late review. It all looks good except that I still had trouble getting the permissions to work when following along. Could you take a look at whether we need to add steps to give the service account permissions to access the bucket? Or maybe someone else can try the tutorial before we publish? I don't want users to get frustrated if they hit similar permissions issues. |
@dberenbaum No worries! Thanks for taking a look! I'm not sure why we seem to be getting different flows with setting up this bucket. Maybe @daavoo could weigh in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @flippedcoder!
Edit: pending the couple typos noted above 😅 .
Looks good! Thinking some more about service accounts, it would be worth it to mention that it's required only in two cases:
I think people would be happy to skip a "setup" step if they can (and get playing around with the project/code sooner) when they're just following the guide step by step, and mentioning CI/CD in the service account section will make it clear to people that that's the part they will need to follow when they're actually setting up dvc with google storage remotes on a real project. |
Co-authored-by: Dave Berenbaum <[email protected]>
Co-authored-by: daniele <[email protected]>
Co-authored-by: daniele <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Dave Berenbaum <[email protected]>
Co-authored-by: Dave Berenbaum <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
da1968b
to
058929e
Compare
Tentative publish date:
06/27/2207/06/22Things left to update: