Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: Using GCP remotes in DVC #3560

Merged
merged 15 commits into from
Jul 6, 2022
Merged

blog: Using GCP remotes in DVC #3560

merged 15 commits into from
Jul 6, 2022

Conversation

flippedcoder
Copy link
Contributor

@flippedcoder flippedcoder commented May 17, 2022

Tentative publish date: 06/27/22 07/06/22

Things left to update:

  • image (make sure to use https://tinypng.com/)
  • comments link
  • technical style (code blocks formatted correctly with dvc, python, yaml, etc)
  • update branch with master

@gatsby-cloud
Copy link

gatsby-cloud bot commented May 17, 2022

Gatsby Cloud Build Report

dvc.org

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 3m

Performance

Lighthouse report

Metric Score
Performance 🔶 60
Accessibility 💚 98
Best Practices 🔶 83
SEO 💚 93

🔗 View full report

@shcheklein shcheklein added C: blog TEMPORARY Content of /blog A: docs Area: user documentation (gatsby-theme-iterative) labels May 18, 2022
@flippedcoder flippedcoder requested a review from dberenbaum May 31, 2022 14:58
@flippedcoder
Copy link
Contributor Author

Hey @julieg18! I'm a little confused by the error here. 😅 We don't have a 2022-05-17 folder or any blog posts published on that day. Do you know why this might be throwing?

@julieg18
Copy link
Contributor

Hey @julieg18! I'm a little confused by the error here. 😅 We don't have a 2022-05-17 folder or any blog posts published on that day. Do you know why this might be throwing?

Looks like #3519 was merged with some missing images, breaking master deployment! I'll open an pr fixing the images!

@flippedcoder
Copy link
Contributor Author

Looks like #3519 was merged with some missing images, breaking master deployment! I'll open an pr fixing the images!

Oh... Sorry about that! 😅 Let me know if you need anything from me!

@julieg18 julieg18 mentioned this pull request May 31, 2022
@julieg18
Copy link
Contributor

Oh... Sorry about that! 😅 Let me know if you need anything from me!

No worries! Pr is opened (#3604) and I requested your review. Though the websites team may approve it before you end up reading this :)

@flippedcoder
Copy link
Contributor Author

No worries! Pr is opened (#3604) and I requested your review. Though the websites team may approve it before you end up reading this :)

Done! I'll get it merged to this branch once it's on master! Thanks @julieg18! I can't believe I forgot to update the image links... 🤦🏽‍♀️

@julieg18 julieg18 temporarily deployed to dvc-org-blog-dvc-gcp-re-esnbab June 2, 2022 12:26 Inactive
@flippedcoder
Copy link
Contributor Author

@dberenbaum Would you mind approving this PR? Unless you see something else, we plan to publish this tomorrow.

@dberenbaum
Copy link
Contributor

Thanks for pinging me @flippedcoder! Sorry for the late review.

It all looks good except that I still had trouble getting the permissions to work when following along. Could you take a look at whether we need to add steps to give the service account permissions to access the bucket? Or maybe someone else can try the tutorial before we publish? I don't want users to get frustrated if they hit similar permissions issues.

@flippedcoder
Copy link
Contributor Author

@dberenbaum No worries! Thanks for taking a look!

I'm not sure why we seem to be getting different flows with setting up this bucket. Maybe @daavoo could weigh in?

Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @flippedcoder!

Edit: pending the couple typos noted above 😅 .

@dtrifiro
Copy link
Contributor

Looks good!

Thinking some more about service accounts, it would be worth it to mention that it's required only in two cases:

  • The bucket is going to be used in a CI/CD scenario
  • The user does not have the GCP CLI installed

I think people would be happy to skip a "setup" step if they can (and get playing around with the project/code sooner) when they're just following the guide step by step, and mentioning CI/CD in the service account section will make it clear to people that that's the part they will need to follow when they're actually setting up dvc with google storage remotes on a real project.

@shcheklein shcheklein temporarily deployed to dvc-org-blog-dvc-gcp-re-esnbab July 5, 2022 15:42 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-blog-dvc-gcp-re-esnbab July 5, 2022 15:53 Inactive
@flippedcoder flippedcoder force-pushed the blog/dvc-gcp-remote branch from da1968b to 058929e Compare July 6, 2022 14:15
@shcheklein shcheklein temporarily deployed to dvc-org-blog-dvc-gcp-re-esnbab July 6, 2022 14:15 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-blog-dvc-gcp-re-esnbab July 6, 2022 14:27 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-blog-dvc-gcp-re-esnbab July 6, 2022 14:31 Inactive
@flippedcoder flippedcoder merged commit 8553549 into main Jul 6, 2022
@flippedcoder flippedcoder deleted the blog/dvc-gcp-remote branch July 6, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: blog TEMPORARY Content of /blog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants