Add default remark plugin definition to theme #3143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogermparent
commented
Dec 29, 2021
| @@ -0,0 +1 @@ | |||
| // noop | |||
There was a problem hiding this comment.
Just something I noticed in other gatsby plugins/themes that seems to be standard practice if you're not using index.js.
shcheklein
added
A: website
|
@julieg18 @rogermparent why this is not merged still? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #3133
This PR adds a default remark transformer definition to our Gatsby theme. It's actually the one from cml.dev and isn't used on dvc.org since dvc.org has some special plugins that cml.dev doesn't, but it seems like the CML version is the one we'd use on most sites anyway.
Ideally, this remark definition can be used on most of our sites that will use this theme.