Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guide: split Comparing Experiments, move Listing content to a new document #3011

Closed
wants to merge 2 commits into from

Conversation

iesahin
Copy link
Contributor

@iesahin iesahin commented Nov 8, 2021

This splits UG: Comparing Experiments page by removing dvc exp list related content to a new page. Adds the new page to the sidebar.

No content changes except the initial sentence in Listing Experiments.

Related #2995

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--w1rfdc November 8, 2021 17:50 Inactive
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Nov 17, 2021

Not sure about thi. We'd have 2 pages that are closely related and now you have to navigate some of it on the left nav. May be confusing and the structure isn't clear. Why "compare" before "list" (nav)?

I think we should first try to summarize the current https://dvc.org/doc/user-guide/experiment-management/comparing-experiments significantly to address some of the tasks in #2995.

p.s. and yes I realize this was one idea we had while reviewing the original PR but seeing it now it's not making much sense to me. Idk what we gain from this as it's presented now (no content changes).

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ug-exp--w1rfdc November 17, 2021 10:42 Inactive
@iesahin
Copy link
Contributor Author

iesahin commented Nov 17, 2021

I can push Listing below in the sidebar.

This was the easiest way to shorten the section. We can summarize the content in a cascading PR.

@jorgeorpinel
Copy link
Contributor

We can summarize the content in a cascading PR.

If we're not separating into 2 pages why cascade it though?

@iesahin
Copy link
Contributor Author

iesahin commented Nov 24, 2021

What do you recommend to do?

@jorgeorpinel
Copy link
Contributor

I think we can close this and discuss/address the bullets in #2995.

@iesahin
Copy link
Contributor Author

iesahin commented Nov 29, 2021

Close per your recommendation. We can discuss this in #2995

@iesahin iesahin closed this Nov 29, 2021
@jorgeorpinel
Copy link
Contributor

Thanks. Agreed.

@jorgeorpinel jorgeorpinel deleted the iesahin/ug-exp-comparing-reorg branch July 29, 2022 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants