yarn upgrade && yarn format-all

[casperdcl]

Using:

• current master (7139bde)
• node v14.17.4
• yarn && npm install as recommended in https://dvc.org/doc/user-guide/contributing/docs#development-environment

Then:

• yarn format-all: 10 files changed, 57 insertions(+), 60 deletions(-)
• npm update: updates 10 package versions in package.json
• yarn upgrade: 5775 insertions(+), 5160 deletions(-) in yarn.lock

Related:

• yarn lint-ts: finds 5 errors (in CI as well as locally) - for follow-up issue?
• config: sync local/CI Prettier and Restyled #2774

[rogermparent]

outdated yarn.lock broke the deploy, just pushed an update

[casperdcl]

Ah so do we need to update the instructions over at https://dvc.org/doc/user-guide/contributing/docs#development-environment to remove mentions of npm and instead use yarn? We have a yarn.lock but not package-lock.json.

[rogermparent]

Other than this one entry:

You may need to resolve dependencies at this point by running:

npm install

It seems that we already do use yarn everywhere on that page. The first mention of npm install -g yarn is just to get yarn on the system, since if a user doesn't have yarn they'll almost certainly have npm. That second one should be changed, though, since after yarn is installed the user shouldn't be running npm.

[rogermparent]

#2785 is up for this, thanks for pointing it out!

[casperdcl]

ok so can this PR be merged @rogermparent? Or would you like to fix the lint-ts stuff first?

[shcheklein]

I think we need to fix the issue, CI should be clean to my mind.

[julieg18]

I think we need to fix the issue, CI should be clean to my mind.

@rogermparent, I can help clear the errors if needed!

[rogermparent]

I can help clear the errors if needed!

@julieg18 That'd be great, thanks! Feel free to ping me if you get stuck on something.

[casperdcl]

lgtm but I can't approve a PR I initiated

[julieg18]

@rogermparent, can you review the lint fixes?

[rogermparent]

One nitpick which looked like it could be a logic problem, but looking at the whole file seems to be nothing but an opportunity for slightly reduced complexity to get the same practical effect.

Everything else looks fine, nice job!

[casperdcl]

yarn lint-ts still yields 5 errors for me 🤔 nvm ignore me

[julieg18]

Actually the deployed site isn't working correctly for me... I'm going to try redeploying.

[casperdcl]

maybe now after another yarn upgrade?

[julieg18]

Working now! @casperdcl, is it working for you? I think we're good to merge if so!

[jorgeorpinel]

As this was rolled back, should we re-try in 2 separate PRs? One for yarn update and another (nested?) one for yarn format-all