-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all experiments #2722
Remove all experiments #2722
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
usage: dvc experiments remove [-h] [-q | -v] [--queue | -A] | ||
[<experiment> [<experiment> ...]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change these parts? 🙂 breaks aligning too
usage: dvc experiments remove [-h] [-q | -v] [--queue | -A] | |
[<experiment> [<experiment> ...]] | |
usage: dvc exp remove [-h] [-q | -v] [--queue | -A] | |
[experiment [experiment ...]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the usage line from
dvc exp remove --help
I guess we need to fix it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I imagined that was it, no worries. We don't need to have the exact same thing in both places. (May be hard to customize in Python argparse). Ok I'm committing this too...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need to fix it there.
p.s. @karajan1001 well if it shows <experiment>
as the argument name I think that should be changed in the core repo, yes. We only use <name>
for option argument metavars I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one matter left here though @karajan1001 ☝️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to fix this?
@karajan1001 like this (will commit):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @karajan1001 ! I've wrapped this one up.
Ugh my bad. One more thing was left here but I merged it... Could you address #2715 (review) here and reopen another PR? Feel free to use the same branch. I can help finish that one too. Thanks again @karajan1001 |
* Remove all experiments * delete workspace option * Update content/docs/command-reference/exp/remove.md * Update content/docs/command-reference/exp/remove.md per iterative#2722 (comment) * Update content/docs/command-reference/exp/remove.md * ref: clarify exp remove -A example Co-authored-by: Jorge Orpinel <[email protected]>
per iterative/dvc#6394