Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cml: document --single, --reuse and --cloud-startup-script #2312

Merged
merged 4 commits into from
Mar 18, 2021
Merged

cml: document --single, --reuse and --cloud-startup-script #2312

merged 4 commits into from
Mar 18, 2021

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Mar 18, 2021

This pull request may fix iterative/cml#450 in conjunction with iterative/cml#451

Please note that all the table rows have been modified because of spacing, but there isn't any significant non-whitespace addition apart from lines 92 93 and 105

@jorgeorpinel
Copy link
Contributor

Hi @0x2b3bfa0, writing "fix iterative/cml#450" in the description above will cause that issue to auto-close when this PR is merged (in case you didn't want that, please change the text).

@0x2b3bfa0
Copy link
Member Author

🙏 Thanks for the reminder, @jorgeorpinel! I used a closing word purposefully, as the other linked pull request has been approved and will be merged soon.

Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review on the 2 options being introduced. But all my suggestions would need a reformatting again since md tables are aligned... (Restyled will do it automatically if needed).

content/docs/cml/self-hosted-runners.md Outdated Show resolved Hide resolved
content/docs/cml/self-hosted-runners.md Outdated Show resolved Hide resolved
content/docs/cml/self-hosted-runners.md Show resolved Hide resolved
content/docs/cml/self-hosted-runners.md Outdated Show resolved Hide resolved
@jorgeorpinel
Copy link
Contributor

@0x2b3bfa0 feel free to commit the updated suggestions above per our conversation, thanks.

jorgeorpinel
jorgeorpinel previously approved these changes Mar 18, 2021
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeorpinel jorgeorpinel dismissed their stale review March 18, 2021 20:59

Broken formatting.

@jorgeorpinel
Copy link
Contributor

So is this already released and ready to be published? If so please merge #2315 (approved).

@0x2b3bfa0
Copy link
Member Author

Yes, the code was released early today, so we're good to merge the documentation. Unfortunately, I can't apply the restyled.io pull request. 😅

@jorgeorpinel jorgeorpinel merged commit ca2e6c6 into iterative:master Mar 18, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the new-cml-options branch March 18, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--reuse and --cloud-startup-script params in docs
2 participants