-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cml: document --single, --reuse and --cloud-startup-script #2312
Conversation
Hi @0x2b3bfa0, writing "fix iterative/cml#450" in the description above will cause that issue to auto-close when this PR is merged (in case you didn't want that, please change the text). |
🙏 Thanks for the reminder, @jorgeorpinel! I used a closing word purposefully, as the other linked pull request has been approved and will be merged soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review on the 2 options being introduced. But all my suggestions would need a reformatting again since md tables are aligned... (Restyled will do it automatically if needed).
Co-authored-by: Jorge Orpinel <[email protected]>
@0x2b3bfa0 feel free to commit the updated suggestions above per our conversation, thanks. |
Co-authored-by: Jorge Orpinel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
So is this already released and ready to be published? If so please merge #2315 (approved). |
Yes, the code was released early today, so we're good to merge the documentation. Unfortunately, I can't apply the restyled.io pull request. 😅 |
This pull request may fix iterative/cml#450 in conjunction with iterative/cml#451
Please note that all the table rows have been modified because of spacing, but there isn't any significant non-whitespace addition apart from lines 92 93 and 105