-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: rename dvc lock
-> dvc freeze
#1380
Conversation
You are out of testsChoose a plan to resume monitoring your Sites and Pull Requests. If you need help, check the Manage Your Plan and Test Usage guide. |
things to take care of:
|
@shcheklein Done. |
Tests fail because they try to check links that are not yet deployed. |
@efiop yep, it's a well know and unfortunate limitation, gonna fix this in #1000 /cc @casperdcl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple minor issues. Is this released though? Otherwise no rush no merge this, right? Thanks
Co-authored-by: Jorge Orpinel <[email protected]>
@jorgeorpinel It is merged. I think current approach is to just merge 1.0 changes into master, no? |
I'm not sure. I thought we were timing all of these meaning just letting them be approved to merge them all at once when 1.0 is released. |
Restyle docs: rename `dvc lock` -> `dvc freeze`
@jorgeorpinel We have a mix of all of them right now. E.g. plots are from 1.0. It makes sense to continue merging. |
Post moretm review/ questions @efiop:
Thanks |
Oops, missed that one. #1404 Thank you! 🙏
I didn't touch that one because it will need to be removed/reworked for 1.0. I'll leave a comment in https://github.com/iterative/dvc.org/pull/1370/files , since it is already there.
Correct.
no such command in 1.0, |
Awesome. |
@jorgeorpinel Just to clarify: |
Per iterative/dvc#3915
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue
(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏