-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added full stop #1288
Added full stop #1288
Conversation
@chaytanyasinha please rebase to fix the CI check |
@shcheklein I think I ran prettier.Can you please tell the command and when to use so that I can cross check. |
I think you can just fetch upstream, pull master, and merge into or rebase your branch, @chaytanyasinha. Or just apply the change again from the latest master and open the PR again. I'm not really sure why the CI check is failing on a file that's not part of this PR @shcheklein was something committed to master directly without formatting by accident? Strange |
@shcheklein @jorgeorpinel can you please tell the prettier command to be used in git bash. I think it's doing some problem from there. |
@chaytanyasinha all the commands used by CI and others are explained here: https://dvc.org/doc/user-guide/contributing/docs#all-commands Your dev environment runs the formatting automatically. The problem here is with a file that you didn't change, not something you caused. It sounds like this has since been fixed in the master branch which is why Ivan suggested you rebase yours. Merging, cherry-picking, or just doing your small change again from the latest master and submitting the PR again should also work. |
@jorgeorpinel okay I got it. Thanks for the help. |
Hey @chaytanyasinha I just applied this myself to my latest branch and tagged you in 67f0648. Thanks |
Added full stop in the end of a sentence in privacy.md