Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: show-md on params/metrics diff #1266

Merged
merged 1 commit into from
May 12, 2020
Merged

doc: show-md on params/metrics diff #1266

merged 1 commit into from
May 12, 2020

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented May 8, 2020

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please chose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Implemented on iterative/dvc#3757

@skshetry skshetry added the A: docs Area: user documentation (gatsby-theme-iterative) label May 8, 2020
@skshetry skshetry self-assigned this May 8, 2020
@shcheklein shcheklein temporarily deployed to dvc-landing-show-md-doc-dnrrx0 May 8, 2020 10:12 Inactive
@jorgeorpinel
Copy link
Contributor

Thanks @skshetry. Can you please link to the core repo PR so we know whether or when it's merged? Bc I'm not seeing this behavior on dvc master branch yet.

Comment on lines 10 to 14
usage: dvc metrics diff [-h] [-q | -v]
[--targets [<path> [<path> ...]]]
[-t <type>] [-x <path>] [-R] [--show-json]
[-t <type>] [-x <path>] [-R]
[--show-json] [--show-md]
[a_ref] [b_ref]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the actual order in which it's printed? I don't see this output in the core repo master branch yet. Thanks

This comment was marked as resolved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the actual order in which it's printed?

Yes, that's the order.

$ dvc metrics diff -h
usage: dvc metrics diff [-h] [-q | -v] [--targets [<paths> [<paths> ...]]] [-R] [--all] [--show-json] [--show-md]
                        [a_rev] [b_rev]

Show changes in metrics between commits
Documentation: <https://man.dvc.org/metrics/diff>

positional arguments:
  a_rev                 Old Git commit to compare (defaults to HEAD)
  b_rev                 New Git commit to compare (defaults to the current workspace)

optional arguments:
  -h, --help            show this help message and exit
  -q, --quiet           Be quiet.
  -v, --verbose         Be verbose.
  --targets [<paths> [<paths> ...]]
                        Metric files or directories (see -R) to show diff for. Shows diff for all metric files by default.
  -R, --recursive       If any target is a directory, recursively search and process metric files.
  --all                 Show unchanged metrics as well.
  --show-json           Show output in JSON format.
  --show-md             Show tabulated output in the Markdown format (GFM).

Note that we still need to readjust the docs for the -t and -x on the metrics. But, I have tried to keep the order for all dvc {metrics,params} diff.

Copy link
Contributor

@jorgeorpinel jorgeorpinel May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're missing [--all] though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take care of it.

@shcheklein shcheklein temporarily deployed to dvc-landing-show-md-doc-dnrrx0 May 11, 2020 10:36 Inactive
Comment on lines +111 to +113
Path Metric Value Change
metrics.json TP 531 4
metrics.json AUC 0.967 0.003
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading formats got affected by the change. Previously it was centered, it's left aligned now.

@shcheklein
Copy link
Member

@skshetry would be great to update bash/zsh scripts as well.

@skshetry
Copy link
Member Author

@shcheklein, I have updated zsh/bash autocompletion scripts.

@shcheklein shcheklein merged commit df7744b into master May 12, 2020
@skshetry skshetry deleted the show-md-doc branch May 12, 2020 14:33
jorgeorpinel added a commit that referenced this pull request May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants