Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regular updates (May 7) and plot updates #1263

Merged
merged 6 commits into from
May 10, 2020
Merged

Regular updates (May 7) and plot updates #1263

merged 6 commits into from
May 10, 2020

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented May 8, 2020 •
edited
Loading

@shcheklein shcheklein temporarily deployed to dvc-landing-2020-05-07-zivvdoo May 8, 2020 02:27 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-05-07-zivvdoo May 9, 2020 02:09 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-05-07-zivvdoo May 9, 2020 02:37 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review May 9, 2020 02:37
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-05-07-zivvdoo May 9, 2020 03:16 Inactive
shcheklein
shcheklein requested changes May 9, 2020
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few minor comments.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-05-07-zivvdoo May 10, 2020 02:42 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented May 10, 2020 •
edited
Loading

Ok @shcheklein but please review my last commit (065f78f) which is pretty big, sorry. Preparing for @dmpetrov's next round on metrics/plots which I believe he intends to start this coming week.

@jorgeorpinel jorgeorpinel requested a review from shcheklein May 10, 2020 02:44
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented May 10, 2020 •
edited
Loading

We're ignoring the link checker wanting new images to be in dvc.org right?

image

https://circleci.com/gh/iterative/dvc.org/3397

@jorgeorpinel
Copy link
Contributor Author

p.s. @dmpetrov: you may want to check the changes I made in the dvc plot ref and subcommands (mainly in the examples): https://dvc-landing-2020-05-07-zivvdoo.herokuapp.com/doc/command-reference/plot

@jorgeorpinel jorgeorpinel changed the title Regular updates (May 7) Regular updates (May 7) ans plot updates May 10, 2020
@jorgeorpinel jorgeorpinel changed the title Regular updates (May 7) ans plot updates Regular updates (May 7) and plot updates May 10, 2020
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-05-07-zivvdoo May 10, 2020 03:03 Inactive
@shcheklein shcheklein merged commit e27937b into master May 10, 2020
@weekly-digest weekly-digest bot mentioned this pull request May 10, 2020
Closed
@jorgeorpinel jorgeorpinel deleted the 2020-05-07 branch June 6, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgeorpinel @shcheklein