Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: run: update --no-exec description #1225

Merged
merged 2 commits into from
May 5, 2020
Merged

docs: run: update --no-exec description #1225

merged 2 commits into from
May 5, 2020

Conversation

efiop
Copy link
Contributor

@efiop efiop commented May 3, 2020

Per iterative/dvc#3729

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please chose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@shcheklein shcheklein temporarily deployed to dvc-landing-efiop-patch-sr3znq May 3, 2020 22:40 Inactive
Comment on lines 156 to 158
stage is actually executed. DVC will add your outputs to `.gitignore` to
prevent possible future conflicts. This is useful if, for example, you need to
build a pipeline (dependency graph) first, and then run it all at once.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly could be worded/explained better. Suggestions are welcome 🙂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I understand this to prevent possible future conflicts to even suggest improvements :)

Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some context/explanation is probably needed unblock this. No need to even change docs - just a plain english what's going on would be suffice.

@shcheklein shcheklein temporarily deployed to dvc-landing-efiop-patch-sr3znq May 5, 2020 12:20 Inactive
@efiop
Copy link
Contributor Author

efiop commented May 5, 2020

Updated the message.

It might be considered an implementation detail even, since it is the same thing that it would do without --no-exec. But still seems to be worth pointing out.

@shcheklein shcheklein merged commit c5782f5 into master May 5, 2020
@shcheklein
Copy link
Member

Thanks @efiop !

@jorgeorpinel jorgeorpinel deleted the efiop-patch-1 branch May 5, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants