Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows development #1205

Merged
merged 1 commit into from
May 2, 2020
Merged

Fix Windows development #1205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@
"scroll": "^3.0.1",
"serve-handler": "^6.1.2",
"slick-carousel": "^1.8.1",
"unist-util-visit": "2.0.2"
"unist-util-visit": "2.0.2",
"upath": "^1.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure ... but should it be part of the devDeps section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it would fit more in the current setup, but technically this is the right place for it and most of those devDependencies should be moved up to regular dependencies. It makes no difference in the practical sense as the switch to YARN_PRODUCTION=false means we keep all deps and devDeps in the same way on deploy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, you are right. For the website there are no difference at all, right?

may be we can keep linters, tests, and other stuff there? may be should move them to optionalDeps? to avoid installing them on Heroku?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway, merging this ... since this one can stay in deps.

},
"devDependencies": {
"@babel/core": "^7.9.0",
Expand Down
2 changes: 1 addition & 1 deletion src/gatsby/utils/resolvers/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const path = require('path')
const path = require('upath')

/** Source Path Resolver Builder
This function makes Gatsby resolvers that connect a node to another node via
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16982,7 +16982,7 @@ unset-value@^1.0.0:
has-value "^0.3.1"
isobject "^3.0.0"

upath@^1.1.1:
upath@^1.1.1, upath@^1.2.0:
version "1.2.0"
resolved "https://registry.yarnpkg.com/upath/-/upath-1.2.0.tgz#8f66dbcd55a883acdae4408af8b035a5044c1894"
integrity sha512-aZwGpamFO61g3OlfT7OQCHqhGnW43ieH9WZeP7QxN/G/jS4jfqUkZxoryvJgVPEcrl5NL/ggHsSmLMHuH64Lhg==
Expand Down