link-check: fix CI daily

[casperdcl]

• fix yarn link-check daily CI exit codes and warnings
• fixes link-check: full cycle issues #1191

[shcheklein]

Looks good! Annoying a bit that we have to repeat certain settings (like extensions? files to exclude?) across different scripts.

[casperdcl]

Looks good! Annoying a bit that we have to repeat certain settings (like extensions? files to exclude?) across different scripts.

Yes, though they're done a bit differently (find | grep -v versus git diff -- ':!'). Still a handful of lines duplicating definition of $base_url and $exclude which could be moved to the sourced utils.sh but not sure if that's good programming practice. What we need is an equivalent of from utils import base_url in bash rather than source utils.sh == from utils import *

[shcheklein]

I think it's pretty common to have config.sh that you'd just source in all other sripts.