Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regular updates (March 18) #1072

Merged
merged 15 commits into from
Mar 26, 2020
Merged

Regular updates (March 18) #1072

merged 15 commits into from
Mar 26, 2020

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Mar 19, 2020

@shcheklein shcheklein temporarily deployed to dvc-landing-2020-03-18-cprujyh March 19, 2020 05:30 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 19, 2020 06:02 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 19, 2020 06:12 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 19, 2020 07:03 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 19, 2020 07:13 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 20, 2020 05:52 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 20, 2020 06:55 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Mar 25, 2020

From 635d6e9#r37945264
image
cmder is an integrated environment ... we also recommend Git Bash above and Anaconda prompt above

Hi, sorry for the delay here @shcheklein. I tried Cmder and didn't love it. It's kind of complicated and not easy to configure. I'm not sure what you mean by an integrated environment or why that would be desirable. To me, the closest to a simple terminal app that can serve as a true Linux console is ideal, and that's what Windows Terminal does (using WSL). It also supports regular cmd and PowerShell.

looks a bit messy now

I agree it's not super clear but is it because of this change? We were already recommending the other 2 before. We're not really recommending them, just mentioning them because they're well known. Maybe we should rec WT first, and then just mention other interesting options (I can re-include Cmder in that list)?

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 25, 2020 03:57 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 25, 2020 04:08 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review March 25, 2020 04:09
@jorgeorpinel jorgeorpinel requested a review from shcheklein March 25, 2020 04:10
@shcheklein
Copy link
Member

To me, the closest to a simple terminal app that can serve as a true Linux console is ideal, and that's what Windows Terminal does (using WSL).

WSL could be slow. sometimes very slow. When we recommend an environment we need to ask data scientists/ML folks what they prefer. All of them have very specific needs, e.g. they should be able to install conda, pandas, numpy, etc .... they need access to GPU ... they crunch a lot of files. I'm just not sure if WSL is a good option. Cmder was recommended in the DS community since conda can be installed (or even comes with it) and other features.

@@ -62,8 +62,8 @@ $ git clone [email protected]:<username>/dvc.org.git
$ cd dvc.org
```

Make sure you have the latest version of [Node.js](https://nodejs.org/en/), and
install [Yarn](https://yarnpkg.com/):
Make sure you have a **recent** version of [Node.js](https://nodejs.org/en/),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does "recent" mean?

Copy link
Contributor Author

@jorgeorpinel jorgeorpinel Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. I'm not sure what's the oldest version this works on, probably its safe to recommend 10+ cc @iAdramelk ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its easier to revert to "latest" but will always work? We can't guarantee it, maybe we should get specific. But up to you, no strong opinion from my part.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I would just specify explicitly the versions we support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is info. I don't currently know exactly. I know the std. node provided by apt-get (Ubuntu) is really old so I had to install like this. @iAdramelk could you chime in here please?

Copy link
Member

@shcheklein shcheklein Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have engines specified as

  "engines": {
    "node": "^12.0.0"
  },

in blog (which will be part of the dvc.org soon). @fabiosantoscode and @iAdramelk should have more context - ping them in Slack if needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinged Fabian but he's probably offline rn. I'm using 12 for now so we can merge this and I can update with whatever they say in another PR later. Going to focus on other doc PRs for now.

@shcheklein
Copy link
Member

Check this link for example - https://www.phoronix.com/scan.php?page=article&item=windows10-okt-wsl&num=2

CmdEr has an option to install it with Git (so you don't need GitBash, Git, etc) - you have shell and git with it - that's why it can be considered a bit more than just terminal.

With Windows Terminal you either have to go with WSL (might be slow for DVC) or you have to install Git Bash and at this point it's not clear what experience is easier - WT or Cmder ... Also I would check how easy it is to install conda, if tqdm is compatible with win terminal (running git bash) ... etc

@jorgeorpinel

This comment has been minimized.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 25, 2020 07:16 Inactive
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Mar 25, 2020

Cmder was recommended in the DS community since conda can be installed
CmdEr has an option to install it with Git

True, the full version comes with Git and SSH built-in but only when running some of the 9 tasks it comes with, I think. Again, not a very easy config:

image

@jorgeorpinel
Copy link
Contributor Author

With Windows Terminal you either have to go with WSL (might be slow for DVC) or you have to install Git Bash

I think Git Bash is a stand alone terminal-like app as well, not something you can run from within other terminals. But it's a good argument: no point using WT with cmd or PowerShell if what we're looking for is a POSIX-like experience... You'd have to install cygwin or something like that.

OK I'm convinced. I'll add Cmder back. Should I mention WT at all?

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 25, 2020 09:03 Inactive
@jorgeorpinel jorgeorpinel requested a review from shcheklein March 25, 2020 09:03
@shcheklein
Copy link
Member

@jorgeorpinel so, WT with WSL is a reasonable approach, we can and we should recommend both of them ... I more worried about use recommending git bash as well above ... and even more that we do it in two different paragraphs ... can we combine all of this somehow - and recommend all three options for example?

@shcheklein

This comment has been minimized.

@shcheklein

This comment has been minimized.

@shcheklein

This comment has been minimized.

@jorgeorpinel

This comment has been minimized.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 25, 2020 23:32 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 25, 2020 23:44 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 26, 2020 00:18 Inactive
@jorgeorpinel

This comment has been minimized.

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-landing-2020-03-18-cprujyh March 26, 2020 00:35 Inactive
@jorgeorpinel jorgeorpinel merged commit de3d91f into master Mar 26, 2020
@jorgeorpinel
Copy link
Contributor Author

@shcheklein shcheklein deleted the 2020-03-18 branch March 27, 2020 20:07
@jorgeorpinel jorgeorpinel added type: enhancement Something is not clear, small updates, improvement suggestions A: docs Area: user documentation (gatsby-theme-iterative) labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants