Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Gatsby migration fixes #1068

Merged
merged 15 commits into from
Mar 19, 2020
Merged

[WIP] Gatsby migration fixes #1068

merged 15 commits into from
Mar 19, 2020

Conversation

pavelgrinchenko
Copy link
Contributor

@pavelgrinchenko pavelgrinchenko commented Mar 18, 2020 •
edited
Loading

Fixes related to issues that we got after migrating to Gatsby.js in this PR

  • 404 code is not returned on 404
  • if I open https://dvc.org/doc/tutorials/versioning#automating-capturing Automatic Capturing is not highlighted on the right sidebar (and it’s not even active)
  • go to the last anchor https://dvc.org/doc/tutorials/versioning#whats-next and then click Interactive Tutorial - behavior between previous version and the current one should be the same (no long scrolling animation)
  • styles are broken (different) in the new version - go carefully through all of them - make sure that docs are identical, inline code blocks, line spacing, list items spacing, notes, notes, cases like titles with links, etc, etc
  • in a Phablet mode Edit on Github button creates a second line (it might be related to styles issue - we already have two lines in the new version, compared to the previous one)
  • SEO problems - run Lighthouse new and old version
  • image subtitles are broken - check this page https://dvc.org/doc/tutorials/versioning , (Who doesn’t love ASCII directory art?)
  • make sure that GA runs the same way as before, with all the events
  • check Sentry - we are getting some new errors, hard to tell what page they come from, from what action

@pavelgrinchenko pavelgrinchenko self-assigned this Mar 18, 2020
@shcheklein shcheklein temporarily deployed to dvc-landing-gatsby-migr-qggesg March 18, 2020 13:37 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-gatsby-migr-qggesg March 18, 2020 14:19 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-gatsby-migr-qggesg March 18, 2020 14:50 Inactive
shcheklein
shcheklein reviewed Mar 18, 2020
View reviewed changes
server.js
directoryListing: false,
headers: [
{
source: '**/*.@(jpg|jpeg|gif|png)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiosantoscode could you please review this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabiosantoscode ??

@shcheklein shcheklein temporarily deployed to dvc-landing-gatsby-migr-qggesg March 18, 2020 17:38 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-gatsby-migr-qggesg March 18, 2020 21:35 Inactive
@pavelgrinchenko pavelgrinchenko force-pushed the gatsby-migration-fixes branch from 1f125da to ef59aa2 Compare March 18, 2020 21:38
@shcheklein shcheklein temporarily deployed to dvc-landing-gatsby-migr-qggesg March 18, 2020 21:38 Inactive
shcheklein
shcheklein reviewed Mar 18, 2020
View reviewed changes
src/utils/resources.js Outdated
new RegExp(regExp).test(url)
)

console.log(url, howToHandle)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it a debug?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Removed it.

@pavelgrinchenko pavelgrinchenko force-pushed the gatsby-migration-fixes branch from ef59aa2 to d7cd2e3 Compare March 19, 2020 08:24
@shcheklein shcheklein temporarily deployed to dvc-landing-gatsby-migr-qggesg March 19, 2020 08:24 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-gatsby-migr-qggesg March 19, 2020 09:08 Inactive
@pavelgrinchenko
Copy link
Contributor Author

make sure that GA runs the same way as before, with all the events

I've checked few events and they was sent. So all seems good.

@shcheklein shcheklein had a problem deploying to dvc-landing-gatsby-migr-qggesg March 19, 2020 09:43 Failure
@pavelgrinchenko pavelgrinchenko force-pushed the gatsby-migration-fixes branch from 4a12169 to 5e7129b Compare March 19, 2020 09:44
@shcheklein shcheklein had a problem deploying to dvc-landing-gatsby-migr-qggesg March 19, 2020 09:44 Failure
@pavelgrinchenko pavelgrinchenko force-pushed the gatsby-migration-fixes branch from 5e7129b to c656d24 Compare March 19, 2020 10:12
@shcheklein shcheklein temporarily deployed to dvc-landing-gatsby-migr-qggesg March 19, 2020 10:12 Inactive
@pavelgrinchenko
Copy link
Contributor Author

check Sentry - we are getting some new errors, hard to tell what page they come from, from what action

Most critical issues were fixed. The rest needs to be watched.

psdcoder added 10 commits March 19, 2020 16:14
@psdcoder
Add 404 error code for not found page
4eac356
@psdcoder
Fix images loaded status checker for the right column in the document…
800b828 
…ation
@psdcoder
Move images helpers to 'src/utils'. Use these helpers for waiting ima…
1715139 
…ges load before scroll to anchor after page change. Remove smooth scroll behavior for scroll to top of the page
@psdcoder
Rename 'property' to 'name' attribute for description and keywords me…
9587977 
…ta tags
@psdcoder
Remove duplication of modal root node
6a69836
@psdcoder
Use 'serve-handler' package for handling trailings slashed in the pro…
8344ef6 
…per way instead of express.static()
@psdcoder
Fix caption styles after code blocks in the docs
36da01d
@psdcoder
Remove wrapper for markdown component
ced9126
@psdcoder
Add compression middleware to server.js
6ad1293
@psdcoder
Load algolia docsearch asynchronously to increase initial page load p…
a46b442 
…erformance
@pavelgrinchenko pavelgrinchenko force-pushed the gatsby-migration-fixes branch from c656d24 to e920e2d Compare March 19, 2020 13:16
@shcheklein shcheklein temporarily deployed to dvc-landing-gatsby-migr-qggesg March 19, 2020 13:17 Inactive
@shcheklein shcheklein temporarily deployed to dvc-landing-gatsby-migr-qggesg March 19, 2020 16:57 Inactive
@shcheklein shcheklein merged commit a629031 into master Mar 19, 2020
@shcheklein shcheklein deleted the gatsby-migration-fixes branch March 27, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein left review comments

Assignees

@pavelgrinchenko pavelgrinchenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelgrinchenko @shcheklein @psdcoder