Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove unnecessary index pages that serve as a table of contents #727

Closed
shcheklein opened this issue Oct 23, 2019 · 13 comments · Fixed by #903
Closed

docs: remove unnecessary index pages that serve as a table of contents #727

shcheklein opened this issue Oct 23, 2019 · 13 comments · Fixed by #903
Labels
A: docs Area: user documentation (gatsby-theme-iterative) type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@shcheklein
Copy link
Member

shcheklein commented Oct 23, 2019

Blocked by #738

E.g. https://dvc.org/doc/user-guide/contributing

It'll be very painful to support them. We will need to keep titles up to date, list of them, snippets, etc, etc.

Let's not use pages like this at all or come with a way to generate them automatically.

cc @dashohoxha

@shcheklein shcheklein added type: enhancement Something is not clear, small updates, improvement suggestions A: docs Area: user documentation (gatsby-theme-iterative) website: eng-doc DEPRECATED JS engine for /doc labels Oct 23, 2019
@jorgeorpinel
Copy link
Contributor

The point of having them is that we can add some text about the purpose of the section, and summary of each page inside. All of those texts are custom, they don't come from inside any of the other pages. So auto-generating them won't be able to get these same results, so I think the decision is either keep them or remove them. If we don't want to have to maintain them, let's just delete all these index.md files.

@shcheklein
Copy link
Member Author

@jorgeorpinel yep, I don't mean pages that have some unique content or some introductory text. I specifically mean pages https://dvc.org/doc/user-guide/contributing that do not have any new content but repeat the structure. Moreover I really like that page, but I understand that it'll be a nightmare to keep those in sync w/o proper tooling.

@dashohoxha
Copy link
Contributor

Let's not use pages like this at all

I have tried "source": false, on sidebar.json, but it doesn't work (unless it is the top level, like understanding-dvc). Maybe it should be fixed on the engine.

come with a way to generate them automatically

Again this seems like it needs to be fixed on the engine. I could be specified with a field like "source": "auto", or "source": "index",

@dashohoxha dashohoxha changed the title automate or don't use or auto generate index pages that serve as a table of contents engine: automate or don't use or auto generate index pages that serve as a table of contents Oct 24, 2019
@dashohoxha
Copy link
Contributor

If we don't want to have to maintain them, let's just delete all these index.md files.

@jorgeorpinel As I said above, currently this is not possible, as it breaks the engine. Maybe this could be regarded as bug too, because I would expect it to work automatically without index pages.

so I think the decision is either keep them or remove them

I agree with @shcheklein , sometimes they are useful, sometimes they are a burden. I think that autogenerating an index page should be the default, unless the "source" is given explicitly, or is specified as false.

@shcheklein
Copy link
Member Author

@dashohoxha

As I said above, currently this is not possible

It should be possible - check understanding DVC and/or changelog sections.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 24, 2019

yep... I specifically mean pages https://dvc.org/doc/user-guide/contributing

Ah, Ok. Never mind Ivan.

I have tried "source": false, on sidebar.json, but it doesn't work (unless it is the top level, like understanding-dvc)... it breaks the engine. Maybe this could be regarded as bug...

I'm able to reproduce this bug. I would say just delete the index pages and open a separate bug issue @dashohoxha. (We could wait for that fix before merging this PR.) All parent slugs with "source": false should behave like understanding-dvc, that opens Collaboration Issues by default. BTW it should also change the URL to .../collaboration-issues no? (part of the bug report)

I think that autogenerating an index page should be the default...

Automatically generating a list of H2s in child documents when no source field is used for a parent slug is an engine feature that could also be worked on, but separate to the change I suggested above.

@shcheklein
Copy link
Member Author

@jorgeorpinel could you please create a ticket to fix the issue with indexes? Do you want to try to take it? :)

@jorgeorpinel jorgeorpinel changed the title engine: automate or don't use or auto generate index pages that serve as a table of contents engine: don't use index pages that serve as a table of contents Oct 25, 2019
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 25, 2019

Opened #738. So this one is now just to delete all indices as I suggested? Updating title

@shcheklein
Copy link
Member Author

shcheklein commented Oct 25, 2019

Yep, I would clarify that not all indexes - only those that do not provide any extra value and can be generated in the future.

@jorgeorpinel jorgeorpinel changed the title engine: don't use index pages that serve as a table of contents engine: remove unnecessary index pages that serve as a table of contents Oct 25, 2019
@jorgeorpinel jorgeorpinel changed the title engine: remove unnecessary index pages that serve as a table of contents docs: remove unnecessary index pages that serve as a table of contents Oct 26, 2019
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 26, 2019

I'm confused, actually. What is the difference between this issue and #738? Seems to me like this one depends on that one at least. We could probably re-merge them?

@shcheklein
Copy link
Member Author

Yeo, this one depends on #738, but they are different anyway. I would keep them separate for simplicity.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jan 7, 2020

OK I'm working on this one now. @shcheklein. One question, what about

? They have useful, unique content but I'm not sure the cmd ref is the best place for those explanations. Should we take the opportunity to move them into a new user-guide: "Basic Concepts" (#550)?

UPDATE: Following up in #903 (comment)

@jorgeorpinel

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants