Gitpod should clone a fork

[jorgeorpinel]

Extracted from #1226 (comment) and #1226 (comment)

I tried using Gitpod from https://dvc.org/doc/user-guide/contributing/docs#development-environment to submit a change. It was all working nicely, (I even installed a VS Code plugin to the IDE.) But after committing with Git, I'm unable to push because I didn't grant Gitpod permission to push directly to dvc.org

Open source contributors will never have this permission. Can it be made so a fork is created in their accounts first, and then Gitpod launched from there?

---

For example, I tried with another account I own, @AyokVoluntarios, which doesn't have push access to this repo, but it also cloned the upstream directly:

So again, even if I tell Github to let Gitpod push to my repos, I simply can't do it from that account.

The user would need to configure the Git remote and branch manually from the IDE. Do you know whether that's the only solution, @nisarhassan12? Thanks

[nisarhassan12]

I tried using Gitpod from https://dvc.org/doc/user-guide/contributing/docs#development-environment to submit a change. It was all working nicely, (I even installed a VS Code plugin to the IDE.) But after committing with Git, I'm unable to push because I didn't grant Gitpod permission to push directly to dvc.org

Thanks, @jorgeorpinel This is happening maybe because you have not granted Gitpod the permissions to do so. You can manage the access control here: https://gitpod.io/access-control/

Open source contributors will never have this permission. Can it be made so a fork is created in their accounts first, and then Gitpod launched from there?

When a repo is opened where you don't have push access and you have made a change and are about to commit, A prompts appears from where one can fork and then push to his fork. Another way to fork is F1 > Fork. I think it would be nice if it's documented in the projects contributing guide.

[jorgeorpinel]

You can manage the access control

Unfortunately Gitpod wants access to manage repo settings and development keys so I don't feel comfortable giving it those permissions from my account, since I have admin access to the repo. Maybe for a developer in an org this would be OK but they will probably have a local dev env anyway.

When a repo is opened where you don't have push access and you have made a change and are about to commit, A prompts appears from where one can fork and then push to his fork. Another way to fork is F1 > Fork. I think it would be nice if it's documented in the projects contributing guide.

Yes, we would need to document this in the Gitpod block quote in https://dvc.org/doc/user-guide/contributing/docs#development-environment, would you like to send a PR @nisarhassan12? Feel free to use a <details> hidden section (example in https://dvc.org/doc/tutorials/get-started/configure)

But it may be turning a little complicated. Not sure how useful it will result. It's definitely a good option to have but... Casual contributors can make small changes directly from Github, and regulars will probably want to run things locally. For example it takes much longer to run the local dev server on Gitpod than on my Windows laptop. But anyway, if you can help us explain the whole process including forking etc up till the pull request is submitted (hopefully it's only a few steps) that would be great.

[jorgeorpinel]

I'm removing the note for now, please revert 87906e2 and complete the guide when possible. Thanks

[nisarhassan12]

Thanks! I'll make a PR soon.

[jorgeorpinel]

No rush. Thank you!

[nisarhassan12]

Hey @jorgeorpinel I have already made this PR #1262

[shcheklein]

Closing this, see motivation here #1262 (comment)