Skip to content

Commit

Permalink
no need to skip docs/user-guide/concepts in page/sidebar generation a…
Browse files Browse the repository at this point in the history 
…s we add content now
  • Loading branch information
@iesahin
iesahin committed Feb 8, 2021
1 parent d38f1df commit 5f7b521
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/gatsby/models/docs/onCreateMarkdownContentNode.js
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
const path = require('path')

async function createMarkdownDocsNode(api, { parentNode, createChildNode }) {
// Suppress page creation for Basic Concepts and the Glossary
// They're only used in tooltips now, but we intend to expand on them later.
if (parentNode.relativeDirectory === 'docs/user-guide/basic-concepts') return
// No need to suppress concepts directory as it contains content now
// if (parentNode.relativeDirectory === 'docs/user-guide/concepts') return

const splitDir = parentNode.relativeDirectory.split('/')
if (splitDir[0] !== 'docs') return
Expand Down

4 comments on commit 5f7b521

@jorgeorpinel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think there was another js file that needed to be changed. Did you look at the closed Basic Concepts PR for now? Sorry, Idk the answer here but @rogermparent probably does.

@jorgeorpinel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this https://github.com/iterative/dvc.org/pull/1944/files?file-filters%5B%5D=.js#diff-c8d27d0a004cb7dcff8d1f42e800ce514106da88412e2fda4dd7673fd9acb2a5

@iesahin
Copy link
Contributor Author

@iesahin iesahin commented on 5f7b521 Feb 9, 2021 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgeorpinel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I noticed you had figured it out after I replied. Sounds good 👍

Please sign in to comment.