lint: use lint-staged for pre-commit hook, eslint everything for CI

per #776 (review)
iterative · Nov 6, 2019 · 36874f9 · 36874f9
1 parent 3576b22
commit 36874f9
Show file tree

Hide file tree

Showing 3 changed files with 503 additions and 8 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -43,7 +43,7 @@ jobs:
 
       - run: yarn format-check
 
-      - run: yarn lint
+      - run: yarn lint-check
 
       - save_cache:
           paths:

diff --git a/package.json b/package.json
@@ -10,7 +10,7 @@
     "start": "NODE_ENV=production node server.js",
     "format-staged": "pretty-quick --staged --no-restage --bail",
     "format-check": "pretty-quick --check --verbose",
-    "lint": "eslint src pages"
+    "lint-check": "eslint src pages"
   },
   "repository": {
     "type": "git",
@@ -64,12 +64,16 @@
     "eslint-plugin-react": "^7.14.3",
     "husky": "^3.0.4",
     "jest": "^24.9.0",
+    "lint-staged": "^10.0.0-1",
     "prettier": "^1.18.2",
     "pretty-quick": "^1.11.1"
   },
   "husky": {
     "hooks": {
-      "pre-commit": "yarn format-staged && yarn lint"
+      "pre-commit": "yarn format-staged && lint-staged"
     }
+  },
+  "lint-staged": {
+    "*.{js,jsx}": "eslint"
   }
 }