Automatically get group id by pid, and change some default value #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karajan1001
force-pushed
the
auto_get_gpid
branch
2 times, most recently
from
643ace0 to
892deb4
Compare
pmrowla
reviewed
Dec 9, 2022
karajan1001
force-pushed
the
auto_get_gpid
branch
6 times, most recently
from
b011e5a to
d4f558d
Compare
When using killpg, we need to call with group id instead of pid 1. Get group id by pid for `killpg` 2. Modify `kill` and `terminate` 's default group to `False` for better compatibility. Co-authored-by: Peter Rowlands (변기호) <[email protected]>
karajan1001
force-pushed
the
auto_get_gpid
branch
from
d4f558d to
32bdebb
Compare
pmrowla
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using killpg, we need to call with group id instead of pid.
related to #100
killpgkillandterminate's default groups toFalsefor better compatibility.