-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plots: require templates to be JSON and treat them as such #23
Labels
Comments
The initial requirement was related to HTML template support. This is where the strings come from. Later So, we can easily refuse the HTML\string requirement and move to full JSON. But this might require some minor template redesign. |
TODO:
|
daavoo
added a commit
that referenced
this issue
Mar 16, 2023
Prevent unnecessary `dumps`/`loads` calls. Closes #23
daavoo
added a commit
that referenced
this issue
Mar 16, 2023
Prevent unnecessary `dumps`/`loads` calls. Closes #23
daavoo
added a commit
that referenced
this issue
Mar 16, 2023
Prevent unnecessary `dumps`/`loads` calls. Closes #23
daavoo
added a commit
that referenced
this issue
Mar 16, 2023
Prevent unnecessary `dumps`/`loads` calls. Closes #23
daavoo
added a commit
that referenced
this issue
Mar 16, 2023
Prevent unnecessary `dumps`/`loads` calls. Closes #23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In our current code, we assume that the template might be in any string format and so we substitute the anchors as strings. We should really start requiring the templates to be JSON, so we could treat them as dicts internally and have a better control over the special vega options. E.g. smoothing from iterative/dvc#3906 , could be handled not with a separate template but a special plot property (iterative/dvc#3906 (comment)).
The text was updated successfully, but these errors were encountered: