[breaking] utils: cleanup copyfile #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review, but I'd wait till tomorrow for merging as it's a breaking change. |
|
Maybe if I stick |
efiop
approved these changes
Dec 12, 2023
|
Decided to merge this, as we have to make breaking changes anyway with Tqdm and TqdmCallback. |
Closed
skshetry
added a commit
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since dvc-data uses callback now on copyfile, we can cleanup unnecessary kwargs from here.
Note that this is a breaking change, as we cap only the major version in dvc-data. So this will require us to release 2.0 version.