Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Bitbucket native uploads #943

Merged
merged 3 commits into from
Apr 10, 2022
Merged

Add support for Bitbucket native uploads #943

merged 3 commits into from
Apr 10, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Apr 10, 2022 •
edited
Loading

Bitbucket Downloads is more similar to GitHub Releases than to GitLab Uploads. Not sure if it's “the right way” of storing report images: images uploaded from the web interfaces use https://bitbucket.org/xhr/:user/:project/image-upload instead

Permissions

[Tokens] must have write or admin access [sic]

Refactored from an unmerged commit I wrote on 2021-09-25 (#930)

@0x2b3bfa0
Bitbucket native uploads (#930)
1015366 
* Update bitbucket_cloud.js

* Make it work

* Fix error logic

* Better yet
@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request ci-bitbucket p2-nice-to-have Low priority labels Apr 10, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from a team April 10, 2022 19:33
@0x2b3bfa0 0x2b3bfa0 self-assigned this Apr 10, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 10, 2022 19:33 Inactive
DavidGOrtega
DavidGOrtega suggested changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have a simple test like gitlab.
Nothing fancy

src/drivers/bitbucket_cloud.js Outdated Show resolved Hide resolved
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 10, 2022 19:47 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 10, 2022 19:58 Inactive
@DavidGOrtega
Copy link
Contributor

Opens:

@0x2b3bfa0 0x2b3bfa0 requested a review from DavidGOrtega April 10, 2022 19:59
@0x2b3bfa0
Copy link
Member Author

Too late! 😉

@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Apr 10, 2022
Closed
@DavidGOrtega
Copy link
Contributor

DavidGOrtega
DavidGOrtega approved these changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@DavidGOrtega
Copy link
Contributor

test is not passing

@DavidGOrtega
Copy link
Contributor

looks like responseBody.error is undefined

DavidGOrtega
DavidGOrtega suggested changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is not passing

@0x2b3bfa0 0x2b3bfa0 force-pushed the bitbucket-native-upload-support branch from 6e198f8 to e68fe42 Compare April 10, 2022 20:07
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 10, 2022 20:07 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 10, 2022 20:25 Inactive
@0x2b3bfa0 0x2b3bfa0 force-pushed the bitbucket-native-upload-support branch from e68fe42 to 0de3ac0 Compare April 10, 2022 20:29
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 10, 2022 20:29 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from DavidGOrtega April 10, 2022 20:43
@0x2b3bfa0
Copy link
Member Author

Still broken, but now because of permissions. I have sent an internal request to grant write access to the test repository.

DavidGOrtega
DavidGOrtega approved these changes Apr 10, 2022
View reviewed changes
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional chaining... lets go for it

👍

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 10, 2022 22:15 Inactive
@DavidGOrtega DavidGOrtega merged commit fdfcb1b into master Apr 10, 2022
@DavidGOrtega DavidGOrtega deleted the bitbucket-native-upload-support branch April 10, 2022 22:28
This was referenced Apr 10, 2022
Closed
Closed
Merged
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Apr 19, 2022
Merged
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Aug 18, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGOrtega DavidGOrtega DavidGOrtega approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
ci-bitbucket enhancement New feature or request p2-nice-to-have Low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x2b3bfa0 @DavidGOrtega