Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snyk] Security upgrade simple-git from 2.48.0 to 3.3.0 #910

Closed
wants to merge 4 commits into from
Closed

[Snyk] Security upgrade simple-git from 2.48.0 to 3.3.0 #910

wants to merge 4 commits into from

Conversation

snyk-bot
Copy link
Contributor

Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

merge advice

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
high severity 691/1000
Why? Recently disclosed, Has a fix available, CVSS 8.1		 Command Injection
SNYK-JS-SIMPLEGIT-2421199		 Yes No Known Exploit

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: simple-git The new version differs by 78 commits.

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

@snyk-bot snyk-bot temporarily deployed to internal March 12, 2022 02:14 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal March 16, 2022 13:18 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal March 16, 2022 13:43 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from casperdcl March 16, 2022 13:49
@0x2b3bfa0 0x2b3bfa0 added the security Sensitive flaws label Mar 16, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal March 16, 2022 15:18 Inactive
@casperdcl
Copy link
Contributor

@0x2b3bfa0 would you recommend closing in favour of #927?

@0x2b3bfa0
Copy link
Member

(No matter whether you're kidding or not) Yes, absolutely! 😄

@0x2b3bfa0 0x2b3bfa0 closed this Apr 4, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the snyk-fix-754cafdf6b21482d33f8ce9dad1b5477 branch April 4, 2022 23:50
@0x2b3bfa0
Copy link
Member

I'm a bit puzzled by @snyk-bot opening several pull requests for the same package, but the most recent should be better as long as it doesn't introduce breaking changes.

@casperdcl
Copy link
Contributor

should be better as long as it doesn't introduce breaking changes

was hoping to not "test in prod" :)

@casperdcl casperdcl mentioned this pull request Apr 5, 2022
Closed
casperdcl added a commit that referenced this pull request Apr 5, 2022
@casperdcl
npm up && npm audit fix --force
4aea39d 
- closes #927
- closes #910
- closes #919
- closes #924
@casperdcl casperdcl mentioned this pull request Apr 5, 2022
Merged
@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Apr 5, 2022 •
edited
Loading

#932 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x2b3bfa0 0x2b3bfa0 0x2b3bfa0 approved these changes

@casperdcl casperdcl Awaiting requested review from casperdcl

Assignees

@snyk-bot snyk-bot

Labels
security Sensitive flaws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snyk-bot @casperdcl @0x2b3bfa0