Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename --cloud-aws-subnet-id to --cloud-aws-subnet #869

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Rename --cloud-aws-subnet-id to --cloud-aws-subnet #869

merged 3 commits into from
Jan 18, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Jan 13, 2022 •
edited
Loading

Closes #868

@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request ui/ux User interface/experience labels Jan 13, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from a team January 13, 2022 14:18
@0x2b3bfa0 0x2b3bfa0 self-assigned this Jan 13, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal January 13, 2022 14:18 Inactive
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Jan 13, 2022
Closed
3 tasks
casperdcl
casperdcl suggested changes Jan 13, 2022
View reviewed changes
bin/cml/runner.js Outdated Show resolved Hide resolved
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal January 17, 2022 16:05 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal January 17, 2022 16:07 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal January 17, 2022 16:08 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from casperdcl January 17, 2022 16:08
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal January 18, 2022 15:25 Inactive
@0x2b3bfa0 0x2b3bfa0 merged commit 1bd4b05 into master Jan 18, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the awsid branch January 18, 2022 17:18
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Apr 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
enhancement New feature or request ui/ux User interface/experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS subnet & security groups: ID vs Name
2 participants
@0x2b3bfa0 @casperdcl