Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry pipe EAGAIN on macOS #732

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Retry pipe EAGAIN on macOS #732

merged 1 commit into from
Sep 23, 2021

Conversation

0x2b3bfa0
Copy link
Member

E... AGAIN, blame on me, from the last bullet point on #703; I fixed an edge case just to break another one.

We should really get rid of pipe-args.js and use something more or less standard like get-stdin as hinted in #67 (comment).

Maintaining yet another cross–platform pipe support library on our own doesn't look like a great idea.

@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working p0-critical Max priority (ASAP) labels Sep 22, 2021
@0x2b3bfa0 0x2b3bfa0 self-assigned this Sep 22, 2021
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 22, 2021 11:53 Inactive
@0x2b3bfa0 0x2b3bfa0 linked an issue Sep 22, 2021 that may be closed by this pull request
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally merge #733 first to prove it was failing? :)

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal September 22, 2021 12:26 Inactive
@casperdcl
Copy link
Contributor

casperdcl commented Sep 22, 2021

https://github.com/iterative/cml/actions/runs/1261868918 macos still seems to pass without this PR owing to cml publish --version working.

Presumably cml publish --md will fail but can't test without comment spam I presume?

@0x2b3bfa0
Copy link
Member Author

0x2b3bfa0 commented Sep 22, 2021

Presumably cml publish --md will fail but can't test without comment spam I presume?

Correctly presumed, both of the times. Testing cml publish implies spamming a repository; either this one (argh!) or an ephemeral one created just for each test (variation of #538)

* ...force pushed to trigger tests again after #733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p0-critical Max priority (ASAP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macos failing
2 participants