-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmask catch-all token exceptions #563
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidGOrtega
approved these changes
May 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We have a couple of this also. One is regarding the GL endpoint @0x2b3bfa0 |
casperdcl
suggested changes
May 27, 2021
It was a lapsus
0x2b3bfa0
changed the title
Remove catch-all block for token exceptions
Avoid hiding token exceptions under a opaque catch-all block
May 28, 2021
0x2b3bfa0
changed the title
Avoid hiding token exceptions under a opaque catch-all block
Avoid hiding token exceptions under an opaque catch-all block
May 28, 2021
casperdcl
approved these changes
May 28, 2021
casperdcl
changed the title
Avoid hiding token exceptions under an opaque catch-all block
Unmask catch-all token exceptions
May 28, 2021
Merged
This was referenced Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Masking all the errors derived from this function is highly counterproductive in some edge cases. At least,
bad credentials
andnot found
are common but separate errors, and mixing them can lead to long and frustrating blind debugging sessions.CML components rely heavily on services we don't control, and errors are hard to reproduce and hard to trace. While the happy path should be as pretty as possible for end users, errors should be as verbose as possible and contain as much useful non-sensitive information as we manage to extract.
As @DavidGOrtega suggested, we may also implement some sort of wrapper and print a few suggestions for the possible causes for each error, but outputting the original error message is a must.
See also