Fix pipe reading logic on Windows #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fs.readSync function throws EOF instead of returning 0 like in other systems. See nodejs/node#35997 for more information.
casperdcl
reviewed
May 14, 2021
| @@ -24,6 +24,7 @@ module.exports.load = (format) => { | |||
|
|
|||
| chunks.push(buffer.slice(0, nbytes)); | |||
| } catch (err) { | |||
| if (err.code === 'EOF') break; // HACK: see nodejs/node#35997 | |||
There was a problem hiding this comment.
should really try-catch just line 21? Also could the error be thrown even though nbytes != 0?
There was a problem hiding this comment.
should really try-catch just line 21
Maybe, though I'm not sure about which line would throw EAGAIN under normal conditions (?)
Also could the error be thrown even though
nbytes != 0?
I don't think so: it just happens when you attempt a read and there are 0 bytes left.
There was a problem hiding this comment.
If we're sure EOF only gets raised when no bytes are left, then this is fine
1 task
casperdcl
approved these changes
May 17, 2021
| @@ -24,6 +24,7 @@ module.exports.load = (format) => { | |||
|
|
|||
| chunks.push(buffer.slice(0, nbytes)); | |||
| } catch (err) { | |||
| if (err.code === 'EOF') break; // HACK: see nodejs/node#35997 | |||
There was a problem hiding this comment.
If we're sure EOF only gets raised when no bytes are left, then this is fine
DavidGOrtega
added a commit
that referenced
this pull request
May 19, 2021
* No await runner (#523) * cml-publish mime and repo (#519) * cml-publish mime and repo * cleanup * image/svg+xml * buffer * resolve * text buffer outputs plain * native bolean * snapshot * Fix pipe reading logic on Windows (#516) The fs.readSync function throws EOF instead of returning 0 like in other systems. See nodejs/node#35997 for more information. * minor doc fixes (#534) * cml-pr command (#510) * test-cml-pr * packages * pre-release * log isci * log isci * user_name * log gitlab url * log gitlab url * short 8 * len paths * no undef * git * files * files * files * files * files * files * files * files * files * files * files * files * files * files * files * files * files * sha2 * sha2 * log filepath * log filepath * log filepath * exists and clean * SHA vs SHA2 * pre-release * pre-release 2 * pre-release 3 * pre-release 3 * pre-release 3 * pre-release 3 * pre-release 3 * pre-release 3 * git back * git back * git back * release * REPO_TOKEN * html_url * cml pr defaults * cml pr defaults * test strict again * CI * vars * shorter params * snapshots and olivaw * test david * BB fix * snapshots * No git sha dependencies (#517) * check head_sha * 0.4.0 Co-authored-by: Helio Machado <[email protected]> Co-authored-by: Casper da Costa-Luis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fs.readSync function throws EOF instead of returning 0 like in other systems.
See nodejs/node#35997 for more information.