Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/contexts #327

Merged
merged 13 commits into from
Nov 1, 2020
Merged

Release/contexts #327

merged 13 commits into from
Nov 1, 2020

Conversation

DavidGOrtega
Copy link
Contributor

Release context PR

#316
#317
#318

DavidGOrtega and others added 8 commits October 28, 2020 17:18
* [wip] CML contexts

* octokit on demand

* token

* clean env before tests

* print env

* yaml

* yaml

* yaml

* yaml

* check

* fix repo env

* fix repo env

* fix repo env

* fix repo env

* check name

* env github tests

* env github tests

* log check

* log check

* no check tessts

* enviromental tests

* workflow eenv

* gitlab uploads and github_token

* snapshots

* Cml contexts (#314)

* token

* clean env before tests

* print env

* yaml

* yaml

* yaml

* yaml

* check

* fix repo env

* fix repo env

* fix repo env

* fix repo env

* check name

* env github tests

* env github tests

* log check

* log check

* no check tessts

* enviromental tests

* workflow eenv

* gitlab uploads and github_token

* snapshots

* docker entrypooint

* docker entrypoint register_runner

* update templates

* token repo

* token repo

* specify driver

* log env

* log env

* update also github.context

* unregister gh runner

* log error

* log error

* log error

* await runners

* await runners

* await runners

* await runners

* await runners 100

* await runners 100

* proc exit

* proc exit

* proc exit

* proc exit

* proc exit

* remove log

* refactor

* Cml contexts sha fix (#315)

* token

* clean env before tests

* print env

* yaml

* yaml

* yaml

* yaml

* check

* fix repo env

* fix repo env

* fix repo env

* fix repo env

* check name

* env github tests

* env github tests

* log check

* log check

* no check tessts

* enviromental tests

* workflow eenv

* gitlab uploads and github_token

* snapshots

* log env

* log env

* update also github.context

* No log

* point to iterative repos

* point to iterative repos without slash

* point to iterative ai

* test slash

* test slash

* fix strip

* removal of strip

* refactor

* slash

* minor refactor

* no console

* Cml contexts sha (#326)

* git sha

* commit_sha

* log

* log gh sha

* log gh sha

* show origin

* remote as repo

* remote as repo

* tests

* remove one test not working on gitlab

* space

* publish backend

* no banckend in publish
* [wip] CML contexts

* octokit on demand

* token

* clean env before tests

* print env

* yaml

* yaml

* yaml

* yaml

* check

* fix repo env

* fix repo env

* fix repo env

* fix repo env

* check name

* env github tests

* env github tests

* log check

* log check

* no check tessts

* enviromental tests

* workflow eenv

* gitlab uploads and github_token

* snapshots

* Cml contexts (#314)

* token

* clean env before tests

* print env

* yaml

* yaml

* yaml

* yaml

* check

* fix repo env

* fix repo env

* fix repo env

* fix repo env

* check name

* env github tests

* env github tests

* log check

* log check

* no check tessts

* enviromental tests

* workflow eenv

* gitlab uploads and github_token

* snapshots

* docker entrypooint

* docker entrypoint register_runner

* update templates

* token repo

* token repo

* specify driver

* log env

* log env

* Destroy one tf resource

* update also github.context

* Cml contexts sha fix (#315)

* token

* clean env before tests

* print env

* yaml

* yaml

* yaml

* yaml

* check

* fix repo env

* fix repo env

* fix repo env

* fix repo env

* check name

* env github tests

* env github tests

* log check

* log check

* no check tessts

* enviromental tests

* workflow eenv

* gitlab uploads and github_token

* snapshots

* log env

* log env

* update also github.context

* No log

* point to iterative repos

* point to iterative repos without slash

* point to iterative ai

* test slash

* test slash

* fix strip

* removal of strip

* refactor

* slash

* minor refactor

* no console

* Cml contexts sha (#326)

* git sha

* commit_sha

* log

* log gh sha

* log gh sha

* show origin

* remote as repo

* remote as repo

* tests

* remove one test not working on gitlab

* space

* publish backend

* no banckend in publish
* [wip] CML contexts

* octokit on demand

* token

* clean env before tests

* print env

* yaml

* yaml

* yaml

* yaml

* check

* fix repo env

* fix repo env

* fix repo env

* fix repo env

* check name

* env github tests

* env github tests

* log check

* log check

* no check tessts

* enviromental tests

* workflow eenv

* gitlab uploads and github_token

* snapshots

* Cml contexts (#314)

* token

* clean env before tests

* print env

* yaml

* yaml

* yaml

* yaml

* check

* fix repo env

* fix repo env

* fix repo env

* fix repo env

* check name

* env github tests

* env github tests

* log check

* log check

* no check tessts

* enviromental tests

* workflow eenv

* gitlab uploads and github_token

* snapshots

* docker entrypooint

* docker entrypoint register_runner

* update templates

* token repo

* token repo

* specify driver

* log env

* log env

* update also github.context

* cml-cloud-runner waits for runner no sleep

* Cml contexts sha fix (#315)

* token

* clean env before tests

* print env

* yaml

* yaml

* yaml

* yaml

* check

* fix repo env

* fix repo env

* fix repo env

* fix repo env

* check name

* env github tests

* env github tests

* log check

* log check

* no check tessts

* enviromental tests

* workflow eenv

* gitlab uploads and github_token

* snapshots

* log env

* log env

* update also github.context

* No log

* point to iterative repos

* point to iterative repos without slash

* point to iterative ai

* test slash

* test slash

* fix strip

* removal of strip

* refactor

* slash

* minor refactor

* no console

* Cml contexts sha (#326)

* git sha

* commit_sha

* log

* log gh sha

* log gh sha

* show origin

* remote as repo

* remote as repo

* tests

* remove one test not working on gitlab

* space

* publish backend

* no banckend in publish
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Member

@dmpetrov dmpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
One comment is inline.

console.log(
await exec('cd / && terraform init && terraform destroy -auto-approve')
await exec(
`cd / && terraform init && terraform destroy -auto-approve ${tf_resource}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is happened in the root dir? Does it create files in root?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes tf files are in root, we are moving from runner workspace having clone the repo to outside that space to just clear the machine

DavidGOrtega and others added 4 commits November 1, 2020 13:09
* Watermark for viewer

* svg

* svg wateremark

* refresh

* new line

* white pixel

* rm-watermark

* cli help uppdatee
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: DavidGOrtega <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants