Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default token to upload release artifacts #1316

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Use default token to upload release artifacts #1316

merged 4 commits into from
Jan 17, 2023

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Jan 17, 2023 •
edited
Loading

3936080711 was failing because secrets.TEST_GITHUB_TOKEN no longer (?) had enough permissions to upload release artifacts and errored with release not found

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal January 17, 2023 04:49 — with GitHub Actions Inactive
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions

This comment was marked as outdated.

Sign in to view
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 17, 2023
View reviewed changes
.github/workflows/test-deploy.yml Fixed Show resolved Hide resolved
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal January 17, 2023 04:59 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

Test Comment

@github-actions
Copy link
Contributor

Test Comment

dacbd
dacbd previously approved these changes Jan 17, 2023
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal January 17, 2023 05:18 — with GitHub Actions Inactive
@0x2b3bfa0 0x2b3bfa0 changed the title Fix release workflow Use default token to upload release artifacts Jan 17, 2023
@github-actions
Copy link
Contributor

Test Comment

@github-actions
Copy link
Contributor

Test Comment

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal January 17, 2023 05:22 — with GitHub Actions Inactive
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review January 17, 2023 05:23
@github-actions
Copy link
Contributor

Test Comment

@github-actions
Copy link
Contributor

Test Comment

@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd January 17, 2023 05:28
@dacbd dacbd merged commit 0aeccdb into master Jan 17, 2023
@dacbd dacbd deleted the eventually-inconsistent branch January 17, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacbd dacbd dacbd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x2b3bfa0 @dacbd