Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden ancillary exec function #1275

Merged
merged 6 commits into from
Dec 6, 2022
Merged

Harden ancillary exec function #1275

merged 6 commits into from
Dec 6, 2022

Conversation

0x2b3bfa0
Copy link
Member

Closes #1273

@0x2b3bfa0 0x2b3bfa0 linked an issue Dec 5, 2022 that may be closed by this pull request
cml pr escape chars #1273
Closed
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal December 5, 2022 17:40 Inactive
@0x2b3bfa0 0x2b3bfa0 self-assigned this Dec 5, 2022
@0x2b3bfa0 0x2b3bfa0 added bug Something isn't working p0-critical Max priority (ASAP) security Sensitive flaws labels Dec 5, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from a team December 5, 2022 17:40
@0x2b3bfa0 0x2b3bfa0 force-pushed the 1273-cml-pr-escape-chars branch from e242aac to ceeb11b Compare December 5, 2022 17:41
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal December 5, 2022 17:42 Inactive
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review December 5, 2022 17:43
@0x2b3bfa0 0x2b3bfa0 requested a review from casperdcl December 5, 2022 17:46
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal December 5, 2022 18:10 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal December 5, 2022 18:10 Inactive
dacbd
dacbd reviewed Dec 6, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM rubber stamp (haven't ran it myself)

src/cml.js Outdated Show resolved Hide resolved
src/drivers/github.js Show resolved Hide resolved
@dacbd dacbd mentioned this pull request Dec 6, 2022
Merged
casperdcl
casperdcl reviewed Dec 6, 2022
View reviewed changes
Copy link
Contributor

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to change foo ${bar} to 'foo', bar.
But seems a bit excessive to change all instances of 'foo bar' to 'foo', 'bar'.

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal December 6, 2022 01:29 Inactive
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal December 6, 2022 01:31 Inactive
@0x2b3bfa0
Copy link
Member Author

But seems a bit excessive to change all instances of 'foo bar' to 'foo', 'bar'.

Do you have in mind any better approach?

dacbd
dacbd reviewed Dec 6, 2022
View reviewed changes
src/drivers/github.js Outdated Show resolved Hide resolved
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal December 6, 2022 01:50 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from dacbd December 6, 2022 01:57
dacbd
dacbd approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rubber_stamp:

@0x2b3bfa0 0x2b3bfa0 merged commit d6df43c into master Dec 6, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the 1273-cml-pr-escape-chars branch December 6, 2022 20:36
dacbd added a commit that referenced this pull request Dec 8, 2022
@dacbd
#1275 follow-up (#1281)
111b06a 
* debug

* debug

* clean up
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Dec 16, 2022
Closed
This was referenced Dec 19, 2022
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperdcl casperdcl casperdcl left review comments

@dacbd dacbd dacbd approved these changes

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
bug Something isn't working p0-critical Max priority (ASAP) security Sensitive flaws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cml pr escape chars
3 participants
@0x2b3bfa0 @dacbd @casperdcl