Provide Docs URLs in --help messaging
#1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasdomas
reviewed
Oct 19, 2022
|
That should be easy enough to add |
dacbd
commented
Oct 19, 2022
0x2b3bfa0
reviewed
Oct 19, 2022
Comment on lines
+38
to
+46
| 'workflow/rerun', | ||
| 'tensorboard/connect', | ||
| 'runner/launch', | ||
| 'repo/prepare', | ||
| 'pr/create', | ||
| 'comment/create', | ||
| 'comment/update', | ||
| 'check/create', | ||
| 'asset/publish' |
There was a problem hiding this comment.
Suggested change
| 'workflow/rerun', | |
| 'tensorboard/connect', | |
| 'runner/launch', | |
| 'repo/prepare', | |
| 'pr/create', | |
| 'comment/create', | |
| 'comment/update', | |
| 'check/create', | |
| 'asset/publish' | |
| 'workflow:rerun', | |
| 'tensorboard:connect', | |
| 'runner:launch', | |
| 'repo:prepare', | |
| 'pr:create', | |
| 'comment:create', | |
| 'comment:update', | |
| 'check:create', | |
| 'asset:publish' |
For consistency with analytics?
There was a problem hiding this comment.
it's only used to import the file, we could but it would and more code in the test :/
There was a problem hiding this comment.
going to be hard to keep this list updated as (sub)commands new are added.
tasdomas
approved these changes
Oct 19, 2022
tasdomas
pushed a commit
that referenced
this pull request
Oct 28, 2022
* initial setup * npm run do_snapshots * now with a test * Update bin/cml.test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some very basic skimming of yargs to see if they had a better mechanism for this but didn't find anything (note on the basic skimming, I find their docs website difficult to read and search)