Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notices to legacy commands #1227

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Conversation

tasdomas
Copy link
Contributor

Closes #1226

@tasdomas tasdomas self-assigned this Oct 12, 2022
0x2b3bfa0
0x2b3bfa0 previously approved these changes Oct 12, 2022
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Approved means that this pull request can be merged pressing the green button at the bottom of this page 👇🏼

@0x2b3bfa0 0x2b3bfa0 changed the title Add deprecation notices to legacy commands. Add deprecation notices to legacy commands Oct 12, 2022
@0x2b3bfa0 0x2b3bfa0 added the ui/ux User interface/experience label Oct 12, 2022
@tasdomas
Copy link
Contributor Author

Updating for better usability in github.

@tasdomas tasdomas marked this pull request as draft October 13, 2022 14:18
@tasdomas tasdomas temporarily deployed to internal October 14, 2022 13:09 Inactive
@tasdomas tasdomas force-pushed the d007-deprecation-notices branch from 8429194 to 082595c Compare October 14, 2022 13:12
@tasdomas tasdomas temporarily deployed to internal October 14, 2022 13:12 Inactive
@tasdomas tasdomas temporarily deployed to internal October 14, 2022 13:29 Inactive
@tasdomas tasdomas temporarily deployed to internal October 14, 2022 13:41 Inactive
@tasdomas
Copy link
Contributor Author

example

@tasdomas tasdomas requested a review from 0x2b3bfa0 October 14, 2022 13:45
@tasdomas tasdomas marked this pull request as ready for review October 14, 2022 13:46
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tasdomas tasdomas merged commit 3087980 into master Oct 14, 2022
@tasdomas tasdomas deleted the d007-deprecation-notices branch October 14, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux User interface/experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy commands should print deprecation warnings
2 participants