fix driver detection

[casperdcl]

• tried to fix - Error: driver not set when trying to launch a runner for a Github Enterprise Repo #1066

[0x2b3bfa0]

I was about to open a pull request with the same change yesterday, but... are you sure it fixes the issue? 🤔

[0x2b3bfa0]

As per the original bug report, this is the error:

cml/src/cml.js

Line 153 in 4ec6517

if (!driver) throw new Error('driver not set');

[casperdcl]

afaik there's nothing wrong with that line - it's correctly raising an error. The real cause must be elsewhere?

[0x2b3bfa0]

The real cause must be elsewhere?

Yes, sure! I still haven't found the GPS coordinates of elsewhere, though.

[0x2b3bfa0]

Class constructor

cml/src/cml.js

Lines 117 to 118 in 9cfa5ab

	class CML {
	constructor(opts = {}) {

cml/src/cml.js

Line 128 in 9cfa5ab

this.driver = driver || inferDriver({ repo: this.repo });

Driver detection function

cml/src/cml.js

Lines 69 to 80 in 4ec6517

	const inferDriver = (opts = {}) => {
	const { repo } = opts;
	if (repo) {
	if (repo.includes('github.com')) return GITHUB;
	if (repo.includes('gitlab.com')) return GITLAB;
	if (/bitbucket\.(com|org)/.test(repo)) return BB;
	}
	if (GITHUB_REPOSITORY) return GITHUB;
	if (CI_PROJECT_URL) return GITLAB;
	if (BITBUCKET_REPO_UUID) return BB;
	};

Thrown error

cml/src/cml.js

Lines 151 to 153 in 4ec6517

	getDriver() {
	const { driver, repo, token } = this;
	if (!driver) throw new Error('driver not set');

[0x2b3bfa0]

I assume that the class constructor will always be called, and the only case where this.driver can remain unset is when none of the inferDriver conditions are met, which seems pretty unlikely to me.

[dacbd]

Perhaps a look at the things @0x2b3bfa0 mentioned is required, but these are clearly wrong, and we can fix them now.

[0x2b3bfa0]

Yes, but #1209 (this) does not fix #1066 unless proven otherwise

[dacbd]

de-link #1066 and merge?

[0x2b3bfa0]

Fine, but doesn't fix #1066