Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cml comment create --publish by default #1208

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Enable cml comment create --publish by default #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
877e2d5
Enable `cml comment create --publish` by default
0x2b3bfa0 Oct 6, 2022
23831a8
Fix test
0x2b3bfa0 Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/cml/comment/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ exports.options = kebabcaseKeys({
},
publish: {
type: 'boolean',
default: true,
description: 'Upload any local images found in the Markdown report'
},
publishUrl: {
Expand Down
2 changes: 1 addition & 1 deletion bin/cml/comment/create.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe('Comment integration tests', () => {
--commit-sha, --head-sha Commit SHA linked to this comment
[string] [default: \\"HEAD\\"]
--publish Upload any local images found in the Markdown report
[boolean]
[boolean] [default: true]
--publish-url Self-hosted image server URL
[string] [default: \\"https://asset.cml.dev\\"]
--watch Watch for changes and automatically update the
Expand Down