Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improper terraform ref causes Extraneous JSON error #1121

Merged
merged 4 commits into from
Aug 5, 2022
Merged

Conversation

dacbd
Copy link
Contributor

@dacbd dacbd commented Aug 5, 2022

The correct terraform field is aws_subnet_id but it was being passed as aws_subnet

@dacbd dacbd temporarily deployed to internal August 5, 2022 16:30 Inactive
@dacbd dacbd added bug Something isn't working p0-critical Max priority (ASAP) cml-runner Subcommand cloud-aws Amazon Web Services external-request You asked, we did labels Aug 5, 2022
@dacbd dacbd requested a review from a team August 5, 2022 16:30
@0x2b3bfa0
Copy link
Member

Was the tfObj assignment necessary? 😅

@dacbd dacbd self-assigned this Aug 5, 2022
@dacbd
Copy link
Contributor Author

dacbd commented Aug 5, 2022

Was the tfObj assignment necessary? 😅

makes hacking and future debugging easier. test

@0x2b3bfa0
Copy link
Member

0x2b3bfa0 commented Aug 5, 2022

I'd prefer proper unit testing over sed hacking, and confess being allergic to unnecessary variables. 🤧 Still, no strong opinions on this.

@dacbd
Copy link
Contributor Author

dacbd commented Aug 5, 2022

@0x2b3bfa0 do you have strong feelings about DEBUG level logging it, IMO this is important information that I often go to for diagnosing issues and it is overly annoying to get at otherwise...

@0x2b3bfa0
Copy link
Member

@dacbd, if it's any better than a mere cat ~/.cml/*/main.tf.json after the command, sounds fine to me.

@dacbd
Copy link
Contributor Author

dacbd commented Aug 5, 2022

cat ~/.cml/*/main.tf.json

considering you have to nullglob and possibly get a large number of results or annoying extract the cml-* id out of the output yes I would prefer a zero effort guaranteed print of the information that I want ⏯️

@dacbd dacbd temporarily deployed to internal August 5, 2022 21:49 Inactive
@dacbd dacbd merged commit d4467e4 into master Aug 5, 2022
@dacbd dacbd deleted the extraneous-json branch August 5, 2022 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cloud-aws Amazon Web Services cml-runner Subcommand external-request You asked, we did p0-critical Max priority (ASAP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants